Re: [PATCH 2/2] Fix console handling during suspend/resume

Pavel Machek
2006-06-14T21:40:48Z

Hi!

> > > And we definitely want to go back to SYSTEM_RUNNING or how is it
> > > called here.
> >
> > Right. A bit too much cut-and-paste ;)
>
> Btw, maybe I didn't quite make this clear enough, but the two patches
> actually make a huge difference for me.

Well, I'm sure they will make huge difference to me, too ;-)))))))))).

The first one is probably harmless/good idea, but I think the second
one will break suspend-to-disk, or at least make it undebuggable.

> My Mac Mini (Intel dual-core CPU) now resumes and suspends in SMP mode
> too, which was not true just a couple of days ago. It even seems to do it
> fairly reliable.

Yep, you are not alone trying to get that working.

> The debugging patch helped me figure out a number of the problems (and
> even more problems that then didn't actually make any difference once I
> started getting things working ;)
>
> And the console fixes is apparently what got things working in SMP mode.

It works for some people _without_ that console fix.

Then, you have irq9 problem that breaks second suspend, right? I've
seen that before, forced the poor soul to report it into kernel
bugzilla, and IIRC ACPI people were already proposing solutions.

Pavel

--
Thanks for all the (sleeping) penguins.