Re: [PATCH 2/2] Fix console handling during suspend/resume

Benjamin Herrenschmidt
2006-06-22T01:33:30Z

On Wed, 2006-06-21 at 18:24 -0700, Linus Torvalds wrote:
>
> On Thu, 22 Jun 2006, Benjamin Herrenschmidt wrote:
> >
> > Linus, You are contradicting yourself a bit I think... On one mailed,
> > you agreed that suspend() would happen in a "live" systems with no
> > quiescing of subsystems and now you say drivers shouldn't bother
>
> Right.
>
> SUSPEND.
>
> Not SNAPSHOT.
>
> The real STR shouldn't actually need to quiesce anything.
>
> But STD isn't suspend. And it damn well needs to quiesce things.
>
> As long as you think of STD as suspend, you're never going to get
> _anywhere_. It's not. It has never been. And it never will be.

Ok, ok... just read my other mail then and pls answer to my objection
about save_state() vs. suspend() :) That is, my worry about the state
actually changing between those 2 calls and restoring the wrong one,
essentially, what is the precise definition of "state".

Ben.