Re: [PATCH 2/2] Fix console handling during suspend/resume

David Brownell
2006-06-24T04:04:10Z

On Friday 23 June 2006 8:12 pm, you wrote:

> For example, on the run-time management, if we shut things down not as a
> "pci_device" but as a "network device" (which just happens to be _bound_
> to a pci device), we could very easily do the highlevel network device
> crap to make sure that we don't get entered that way _first_. And do it in
> just one place.

Heh, I said as much in a recent note. The issue is that the network
stack doesn't know suspend from joe. If "eth0" had a real "struct device",
that solution should work ... and simplify lots of driver suspend and
resume methods. Backwards compat would be an issue though.

> > One thing that might help us get there is if we passed a suspend notification
> > to the class devices (i.e. the higher level subsystems).
>
> Good point. We probably should. That really really makes sense, and that
> also automagically solves the "network device" issue.

I'm not sure doing that with class devcies is the right idea, at least
until they show up in the driver model tree as physical children of the
parent hardware (so that the driver model tree automatically handles
sequence constraints.

- Dave