Re: [PATCH 2/2] Fix console handling during suspend/resume

Linus Torvalds
2006-06-22T23:19:46Z

On Fri, 23 Jun 2006, Benjamin Herrenschmidt wrote:
>
> The main reason is the video problem (chips not coming back on resume
> and needing a POST). This has always been the main issue and that's what
> is causing STR not to work for a lot of people.

No.

Not for me. Every single time something doesn't work for me, I just plug
it into the network and try to debug it over the net.

Not on _one_ laptop has that helped. Ever.

Maybe I just happen to have screwy laptops, but I don't believe so.

It wasn't the reason on the mac mini either.

> The model does and I think your model would 1- break all existing
> drivers that got it right since they have to be changed

Actually, it won't break a single driver for STR.

Why? Because if you do it the old way, STR will still happen to work. I'm
just giving you a separate phase.

But you're not interested in facts, are you? Nope.

> and 2- won't
> help with the actual problems :)

So you say. Have you actually ever done anything to make debugging easier?

Nope. In the years I've been frustrated with suspend, nobody has ever done
anything to this. And now I have to push through changes, just because
people think that "status quo" is acceptable.

> I've brought a real concern that you'll resume devices in a different
> state than what was last set at suspend time and change a model that
> isn't broken.

And I've explained several times that your concerns aren't problems. You
just ignore it.

Linus