Re: [PATCH 2/2] Fix console handling during suspend/resume

Rafael J. Wysocki
2006-06-15T09:39:14Z

On Thursday 15 June 2006 01:32, Pavel Machek wrote:
> Hi!
>
> > > Actually, no, it is not.
> > >
> > > It happens to be almost okay for s2ram, but it will mean no messages
> > > for suspend to disk... and that is bad.
> > >
> > > Console subsystem should be stopped when console device is stopped,
> > > and restarted when console device is restarted.
> >
> > Well, I don't know. In ususpend we only use pm_prepare/restore_console()
> > during resume and we can live without that at all.
>
> Linus has examples why console stopping is neccessary (netconsole
> case)... so I do not think we can live without that.
>
> Cleanest solution would be if console driver simply responded to
> device_suspend() and do all neccessary stuff...

Agreed.

BTW, is there any reason for which the console suspend/resume routines are
not called from device_suspend()?

Rafael