Re: [PATCH 2/2] Fix console handling during suspend/resume

Benjamin Herrenschmidt
2006-06-16T01:26:28Z

> Sure, harm IS done.
>
> Suspending a device before everybody else has saved their state is
> fundamentally and deeply wrong. You do not know whether other devices
> might need that device for their state save.

Well, solving that problem is exactly why we have the PM callbacks in
bus hierarchy. In fact, we have talked several times about having the PM
tree be orthogonal to the bus tree and make it a dependency graph
instead to handle weird setups where the PM dependencies don't exactly
match the bus tree, but I don't think that was actually implemented.

> You may, for example, have devices that literally have so much state that
> they need user help to save it - which in turn means that they must be
> saved before you have suspended other and UNRELATED devices. X itself is
> actually an example of this, but so might be anything with firmware, for
> example).

X is an interesting example especially if you put GL in the picture...
there's shitload of state to be saved by userland including the textures
in video memory etc... (or at least ways to restore them) and the GL API
doesn't provide any interface to do that.

> (Right now, we actually end up saving firmware in kernel memory or do
> things like that, so that we can resume it. That's really a hack for the
> bigger problem of not having multiple stages of save/restore.)

Yes, see my other message about that.

> It's not just firmware. It could be things like devices that literally
> have user processes handling connection setup etc for them.

Yes.

> So the whole notion of mixing "save state" and "suspend" is fundamentally
> wrong. It has _always_ been wrong. And it's very fundamentally wrong in a
> way that makes me say that unless you can separate the two (not just in
> a technical sense, but in the sense of how people literally _think_ about
> the suspend problem), we can probably _never_ fix the deeper issues.

Well, the problem I would argue is that what you just described isn't
"save_state" as much as it is "prepare for suspend". More like allocate
storage for state etc... the actual state itself is not stable until all
processing of requests is halted, which implies suspend for the reason
explained already, mostly that once you have stopped processing
requests, your child drivers can't use you to communicate with their
hardware device.

Ben.