Re: [PATCH 2/2] Fix console handling during suspend/resume

Linus Torvalds
2006-06-15T20:28:33Z

On Thu, 15 Jun 2006, Pavel Machek wrote:
>
> Why? We are saving state to memory, we should not need any other
> devices to do that.

Hell no, we're not.

> Well, for devices that are so complex that userspace support is
> needed... yes, you are right, separate pass would be
> needed. Fortunately, such devices are not too common.

"Not too common"?

Having a graphical console is a hell of a lot more common than just about
any other device I can imagine, with the possible exception of USB these
days.

> Well, doing half-switch would be cleaner in s2ram case, agreed. For
> s2disk, having console to write on is actually very nice.

The thing is, splitting up save and suspend woul dget exactly that. The
only thing you couldn't see is the very final suspend, but that should
also be the part that literally does the least.

In fact, done right, if you know the machine powers off, the final suspend
should literally not be needed. "Remove power globally" is actually a very
good suspend/shutdown mechanism that doesn't even need any driver support ;)

Linus