Re: [PATCH 2/2] Fix console handling duringsuspend/resume

Re: [PATCH 2/2] Fix console handling duringsuspend/resume

[Gross, Mark]

>-----Original Message-----
>From: linux-pm-bounces@lists.osdl.org
[mailto:linux-pm-bounces@lists.osdl.org] On Behalf Of Linus
>Torvalds
>Sent: Wednesday, June 28, 2006 8:24 PM
>To: Greg KH
>Cc: David Brownell; linux-pm@lists.osdl.org; Pavel Machek
>Subject: Re: [linux-pm] [PATCH 2/2] Fix console handling
duringsuspend/resume
>
>
>
>On Wed, 28 Jun 2006, Greg KH wrote:
>>
>> Any thoughts as to applying your patch to the tree or not?  No
objection
>> from me if you want to.
>
>I've not actually had anybody report any testing success from it, and
>since I don't use suspend-to-disk, for example, if would be good to
have
>verification.
>
>AS FAR AS I CAN TELL the patch won't actually change any behaviour (I
have
>actually been running for the last few days with the separate patch
that
>_does_ do that - moves the PCI config suspend/resume to the late/early
>rsume phase), but hey, mistakes happen.
>

Shouldn't this type of thing go through the MM-tree first for these
reasons?


--mgross

Re: [PATCH 2/2] Fix console handling duringsuspend/resume

[Greg KH]

On Thu, Jun 29, 2006 at 01:13:03PM -0700, Gross, Mark wrote:
> >AS FAR AS I CAN TELL the patch won't actually change any behaviour (I
> have
> >actually been running for the last few days with the separate patch
> that
> >_does_ do that - moves the PCI config suspend/resume to the late/early
> >rsume phase), but hey, mistakes happen.
> >
> 
> Shouldn't this type of thing go through the MM-tree first for these
> reasons?

Good point, that's probably the correct way to do this for such a core
change.

thanks,

greg k-h

Re: [PATCH 2/2] Fix console handling duringsuspend/resume

[David Brownell]

> > Shouldn't this type of thing go through the MM-tree first for these
> > reasons?
> 
> Good point, that's probably the correct way to do this for such a core
> change.

Yes please.  :)

It doesn't conflict with the PRETHAW fixes.

After sanity testing, then the issue will be that folk should
start seeing how this updated infrastructure should be used, yes?

- Dave