Re: [RFC] PowerOP Take 3, ARM OMAP1 platform support 3/5

David Brownell
2006-07-31T21:24:42Z

On Sunday 30 July 2006 11:59 pm, Vitaly Wool wrote:
> > > Let me try to set it this way.
> > > struct powerop_point is an arch independent piece in the sense that any
> > > platform
> > > which leverages PorewOP concept should implement struct powerop_point.
> > > struct powerop_point is fundamental component that has to be defined by
> > > a platfrom.
> >
> > We're not communicating here ... if the contents are arch-specific,
> > it doesn't matter to the interface except that it exist. A better
> > way to define it would be:
> >
> > struct powerop_point {
> > struct kobject kobj;
> > void *arch_hook;
> > // presumably there will be method hooks too, like
> > int (*enter_prepare)(struct powerop_point *);
> > int (*enter)(struct powerop_point *);
> > int (*enter_complete)(struct powerop_point *);
> > };
> >
> > where that "void *" is the entire arch hook, and the kobj holds the
> > name and represents the /sys/power/... directory for that arch.
>
> I do agree with David here (oh my, I'm in agreement with David on
> something, it's unbelievable ;)

We're allowed to agree when we're both right. :)

Nitpick to my explanation: that kobject would represent the sysfs
directory for that set of operating points, not the arch.

- Dave