Re: [RFC] PowerOP Take 3, ARM OMAP1 platform support 3/5

David Brownell
2006-07-23T16:24:50Z

On Thursday 20 July 2006 1:01 pm, Eugeny S. Mints wrote:
> +struct powerop_point {
> +       unsigned int v;         /* voltage in mV */
> +       unsigned int dpll;      /* in KHz */
> +       unsigned int cpu;       /* CPU frequency in KHz */
> +       unsigned int tc;        /* in KHz */
> +       unsigned int per;       /* in KHz */
> +       unsigned int dsp;       /* in KHz */
> +       unsigned int dspmmu;    /* in KHz */
> +       unsigned int lcd;       /* in KHz */
> +};

A few comments:

- This should be part of patch #4; it's not truly separate.

- I take it "v" is CPU voltage rather than some random component?
Either way, there seems to be an omission here since boards
could have multiple voltages to care about ...

- In general, shouldn't an operating point be board-specific, so
that the parts of the system outside the SOC can be included?

- I'd still rather see operating points be identified by a name
string of some kind so that the userspace API resembles that
of /sys/power/state: just write the state name to that file.

Still looking at the patches, otherwise.

- Dave