Re: [linux-pm] [patch, rft] amd74xx: implement suspend-to-ram

Pavel Machek
2006-07-26T09:02:04Z

Hi!

> > and please don't do this. Suspend-to-disk will call
> > amd74xx_resume when it needs to talk to the disk.
>
> I don't understand the rest of this comment. That code looks
> correct (other than calling the goofy/broken pci_choose_state thing);
> PM_EVENT_FREEZE and PM_EVENT_PRETHAW should not disable the device.

Well, I'd prefer PM_EVENT_FREEZE and PM_EVENT_SUSPEND to be the same
code (i.e. remove the if() and just do

> > > + pci_disable_device(dev);
> > > + pci_set_power_state(dev, pci_choose_state(dev, state));

unconditionaly). It should also work, and not really be slower.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html