Re: [RFC][PATCH -mm 3/5] swsusp: Fix handling of highmem

Rafael J. Wysocki
2006-08-09T12:07:19Z

Hi,

On Wednesday 09 August 2006 13:51, Pavel Machek wrote:
> > Make swsusp handle highmem pages similarly to the pages of the "normal"
> > memory.
>
> Is it feasible to create kernel/power/highmem.c?

Not really ...

> > include/linux/suspend.h | 6
> > kernel/power/power.h | 2
> > kernel/power/snapshot.c | 822 ++++++++++++++++++++++++++++++++++++------------
> > kernel/power/swap.c | 2
> > kernel/power/swsusp.c | 53 +--
> > kernel/power/user.c | 2
> > mm/vmscan.c | 3
> > 7 files changed, 658 insertions(+), 232 deletions(-)
>
> +400 lines for highmem... I hope highmem dies, dies, dies. Anyway, I'd
> hate to debug this at the same time as the bitmap code. Can we get the
> bitmaps in, wait for a while, and only then change highmem handling?

Sure, why not. I'll prepare a series without the highmem patch for now.

Rafael