Re: [RFC][PATCH -mm 1/5] swsusp: Introduce memory bitmaps

Pavel Machek
2006-08-09T11:27:01Z

Hi!

> > > Introduce the memory bitmap data structure and make swsusp use in the suspend
> > > phase.
> > >
> > > The current swsusp's internal data structure is not very efficient from the
> > > memory usage point of view, so it seems reasonable to replace it with a data
> > > structure that will require less memory, such as a pair of bitmaps.
> >
> > Well, 500 lines of code for what... 0.25% bigger image? I see it
> > enables you to do some cleanups... but could we get those cleanups
> > without those 500 lines? :-).
>
> Out of the 500 lines, something like 100 are comments and other 50 are
> definitions of structures. ;-)

Yes, and of the 100 lines of comments, 10 are fixmes :-).

> Seriously speaking, I could do that without the bitmaps, but the code wouldn't
> be that much shorter. Apart from this, I would need to introduce yet another
> type of PBEs (for storing pfns) and try not to get lost in the resulting mess.
>
> Instead of doing this I prefer to add some extra code to set up a decent data
> structure and just use it.

Okay, I guess that if we need to change the structure anyway, we may
well use the effective structure...

Pavel