Re: [RFC][PATCH -mm 1/5] swsusp: Introduce memory bitmaps

Pavel Machek
2006-08-09T10:31:20Z

Hi!

> Introduce the memory bitmap data structure and make swsusp use in the suspend
> phase.
>
> The current swsusp's internal data structure is not very efficient from the
> memory usage point of view, so it seems reasonable to replace it with a data
> structure that will require less memory, such as a pair of bitmaps.

Well, 500 lines of code for what... 0.25% bigger image? I see it
enables you to do some cleanups... but could we get those cleanups
without those 500 lines? :-).

> kernel/power/power.h | 3
> kernel/power/snapshot.c | 605 ++++++++++++++++++++++++++++++++++++++++++------
> kernel/power/swsusp.c | 5
> 3 files changed, 542 insertions(+), 71 deletions(-)