Re: [RFC][PATCH] PM: Use suspend_console in swsusp and make it configureable

Pavel Machek
2006-08-16T10:41:43Z

Hi!

> The appended patch does the following:
>
> 1) Adds suspend_console() and resume_console() to the suspend-to-disk code
> paths so that people using netconsole are safe with swsusp.

> 2) Adds a Kconfig option allowing us to disable suspend_/resume_console()
> if need be.

Slightly ugly, but I guess that is the way to go.

> 3) Marks CONFIG_PM_TRACE as dangerous.

I do not think that is enough. "(WILL TRASH YOUR CMOS)" would be more
suitable. Dangerous is "may cause problems to you". This is "will
cause problems to you". And for this to be useful, people have to edit
sources, anyway.

Pavel

Can we just delete the config option?
> Index: linux-2.6.18-rc4-mm1/kernel/power/Kconfig
> ===================================================================
> --- linux-2.6.18-rc4-mm1.orig/kernel/power/Kconfig
> +++ linux-2.6.18-rc4-mm1/kernel/power/Kconfig
> config PM_TRACE
> - bool "Suspend/resume event tracing"
> + bool "Suspend/resume event tracing (DANGEROUS)"
> depends on PM && PM_DEBUG && X86_32 && EXPERIMENTAL
> default n
> ---help---

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html