T60 not coming out of suspend to RAM

T60 not coming out of suspend to RAM

[Michael S. Tsirkin]

Hi!
I'm running Linus' git tree on my thinkpad T60.
It generally seems to work fine after suspend to disk.
However, the system does not come out of suspend to ram,
with screen staying blank. I'm looking for hints for debugging this.

If I set suspend/resume event tracing, I see this in dmesg
after reboot:

dmesg -s 1000000 | grep 'hash matches'
  hash matches drivers/base/power/resume.c:42
  hash matches device serio2

serio2 seems to be the psmouse device:
ls /sys/bus/serio/drivers/psmouse/
bind bind_mode description serio0 serio2 unbind

Does this mean the mouse driver blocks the resume?

I've rebuilt psmouse as a module, unloaded it before suspend, and now
I see the same behaviour but after reboot:
dmesg -s 1000000 | grep 'hash matches'
  hash matches drivers/base/power/resume.c:42
  hash matches device i2c-9191

Which is somewhat weird because
ls /sys/bus/i2c/devices
does not list any i2c devices

I could continue disabling stuff - but I am looking in the
correct place even? How do you debug resume issues?

Thanks,

-- 
MST

Re: T60 not coming out of suspend to RAM

[Pavel Machek]

Hi!

> I'm running Linus' git tree on my thinkpad T60.
> It generally seems to work fine after suspend to disk.
> However, the system does not come out of suspend to ram,
> with screen staying blank. I'm looking for hints for debugging this.
> 
> If I set suspend/resume event tracing, I see this in dmesg
> after reboot:
> 
> dmesg -s 1000000 | grep 'hash matches'
>   hash matches drivers/base/power/resume.c:42
>   hash matches device serio2
> 
> serio2 seems to be the psmouse device:
> ls /sys/bus/serio/drivers/psmouse/
> bind bind_mode description serio0 serio2 unbind
> 
> Does this mean the mouse driver blocks the resume?
> 
> I've rebuilt psmouse as a module, unloaded it before suspend, and now
> I see the same behaviour but after reboot:
> dmesg -s 1000000 | grep 'hash matches'
>   hash matches drivers/base/power/resume.c:42
>   hash matches device i2c-9191
> 
> Which is somewhat weird because
> ls /sys/bus/i2c/devices
> does not list any i2c devices
> 
> I could continue disabling stuff - but I am looking in the
> correct place even? How do you debug resume issues?

Yes, disabling stuff is way to go. Just disable everything, and binary
search from there :-).
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: T60 not coming out of suspend to RAM

[Michael S. Tsirkin]

OK, it turns out the problem was with running SATA drive in AHCI mode.

After applying the following patch from Forrest Zhao
http://lkml.org/lkml/2006/7/20/56
both suspend to disk and suspend to ram work fine now.
This patch is going into 2.6.18, isn't it?

Huge thanks to Thomas Glanzman for help in tracking this down.
You rock.

-- 
MST

Re: T60 not coming out of suspend to RAM

[Pavel Machek]

On Mon 2006-08-28 16:53:58, Michael S. Tsirkin wrote:
> OK, it turns out the problem was with running SATA drive in AHCI mode.
> 
> After applying the following patch from Forrest Zhao
> http://lkml.org/lkml/2006/7/20/56
> both suspend to disk and suspend to ram work fine now.
> This patch is going into 2.6.18, isn't it?

Not sure, check latest -rc5, and if it is not there, ask akpm...

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: T60 not coming out of suspend to RAM

[Michael S. Tsirkin]

Quoting r. Pavel Machek <pavel@ucw.cz>:
> Subject: Re: T60 not coming out of suspend to RAM
> 
> On Mon 2006-08-28 16:53:58, Michael S. Tsirkin wrote:
> > OK, it turns out the problem was with running SATA drive in AHCI mode.
> > 
> > After applying the following patch from Forrest Zhao
> > http://lkml.org/lkml/2006/7/20/56
> > both suspend to disk and suspend to ram work fine now.
> > This patch is going into 2.6.18, isn't it?
> 
> Not sure, check latest -rc5, and if it is not there, ask akpm...
> 

Andrew, this is going into 2.6.18, isn't it? I don't see it in -rc5.

-- 
MST

Re: T60 not coming out of suspend to RAM

[Andrew Morton]

On Mon, 28 Aug 2006 20:19:26 +0300
"Michael S. Tsirkin" <mst@mellanox.co.il> wrote:

> Quoting r. Pavel Machek <pavel@ucw.cz>:
> > Subject: Re: T60 not coming out of suspend to RAM
> > 
> > On Mon 2006-08-28 16:53:58, Michael S. Tsirkin wrote:
> > > OK, it turns out the problem was with running SATA drive in AHCI mode.
> > > 
> > > After applying the following patch from Forrest Zhao
> > > http://lkml.org/lkml/2006/7/20/56
> > > both suspend to disk and suspend to ram work fine now.
> > > This patch is going into 2.6.18, isn't it?
> > 
> > Not sure, check latest -rc5, and if it is not there, ask akpm...
> > 
> 
> Andrew, this is going into 2.6.18, isn't it? I don't see it in -rc5.
> 

It looks like Forrest's stuff is all queued up in the libata devel tree,
although in a significantly different-looking form.

So no, right now it doesn't look good for 2.6.18.

Re: T60 not coming out of suspend to RAM

[Michael S. Tsirkin]

Quoting r. Andrew Morton <akpm@osdl.org>:
> Subject: Re: T60 not coming out of suspend to RAM
> 
> On Mon, 28 Aug 2006 20:19:26 +0300
> "Michael S. Tsirkin" <mst@mellanox.co.il> wrote:
> 
> > Quoting r. Pavel Machek <pavel@ucw.cz>:
> > > Subject: Re: T60 not coming out of suspend to RAM
> > > 
> > > On Mon 2006-08-28 16:53:58, Michael S. Tsirkin wrote:
> > > > OK, it turns out the problem was with running SATA drive in AHCI mode.
> > > > 
> > > > After applying the following patch from Forrest Zhao
> > > > http://lkml.org/lkml/2006/7/20/56
> > > > both suspend to disk and suspend to ram work fine now.
> > > > This patch is going into 2.6.18, isn't it?
> > > 
> > > Not sure, check latest -rc5, and if it is not there, ask akpm...
> > > 
> > 
> > Andrew, this is going into 2.6.18, isn't it? I don't see it in -rc5.
> > 
> 
> It looks like Forrest's stuff is all queued up in the libata devel tree,
> although in a significantly different-looking form.
> 
> So no, right now it doesn't look good for 2.6.18.
> 

Ugh, more's the pity :(
How about merging this one patch? T60 is only half as useful without it (no disk
after resume), and the rate of changes in libata is high so just using a patch
is gonnu be painful in the long run.

-- 
MST

Re: T60 not coming out of suspend to RAM

[Pavel Machek]

Hi!

> > > > > OK, it turns out the problem was with running SATA drive in AHCI mode.
> > > > > 
> > > > > After applying the following patch from Forrest Zhao
> > > > > http://lkml.org/lkml/2006/7/20/56
> > > > > both suspend to disk and suspend to ram work fine now.
> > > > > This patch is going into 2.6.18, isn't it?
> > > > 
> > > > Not sure, check latest -rc5, and if it is not there, ask akpm...
> > > > 
> > > 
> > > Andrew, this is going into 2.6.18, isn't it? I don't see it in -rc5.
> > > 
> > 
> > It looks like Forrest's stuff is all queued up in the libata devel tree,
> > although in a significantly different-looking form.
> > 
> > So no, right now it doesn't look good for 2.6.18.
> > 
> 
> Ugh, more's the pity :(
> How about merging this one patch? T60 is only half as useful without it (no disk
> after resume), and the rate of changes in libata is high so just using a patch
> is gonnu be painful in the long run.

I guess you need to convince SATA maintainer that patch is safe before
it can go in...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: T60 not coming out of suspend to RAM

[Michael S. Tsirkin]

Quoting r. Pavel Machek <pavel@suse.cz>:
> Subject: Re: T60 not coming out of suspend to RAM
> 
> Hi!
> 
> > > > > > OK, it turns out the problem was with running SATA drive in AHCI mode.
> > > > > > 
> > > > > > After applying the following patch from Forrest Zhao
> > > > > > http://lkml.org/lkml/2006/7/20/56
> > > > > > both suspend to disk and suspend to ram work fine now.
> > > > > > This patch is going into 2.6.18, isn't it?
> > > > > 
> > > > > Not sure, check latest -rc5, and if it is not there, ask akpm...
> > > > > 
> > > > 
> > > > Andrew, this is going into 2.6.18, isn't it? I don't see it in -rc5.
> > > > 
> > > 
> > > It looks like Forrest's stuff is all queued up in the libata devel tree,
> > > although in a significantly different-looking form.
> > > 
> > > So no, right now it doesn't look good for 2.6.18.
> > > 
> > 
> > Ugh, more's the pity :( How about merging this one patch? T60 is only half
> > as useful without it (no disk after resume), and the rate of changes in
> > libata is high so just using a patch is gonnu be painful in the long run.
> 
> I guess you need to convince SATA maintainer that patch is safe before
> it can go in...

Right.

Jeff, could you please ack whether the following patch from Forrest Zhao
is safe for 2.6.18?
http://lkml.org/lkml/2006/7/20/56

Without it, no disk access is possible after resume from suspend-to-ram
on my T60.

-- 
MST