From: Dave Jones <davej@redhat.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Len Brown <lenb@kernel.org>, Jeff Garzik <jeff@garzik.org>,
linux-acpi@vger.kernel.org,
Linux-pm mailing list <linux-pm@lists.osdl.org>
Subject: Re: T30 boot hang with CONFIG_PM_LEGACY=n
Date: Wed, 27 Sep 2006 13:15:12 -0400 [thread overview]
Message-ID: <20060927171512.GF997@redhat.com> (raw)
In-Reply-To: <20060927144731.GA3641@srcf.ucam.org>
On Wed, Sep 27, 2006 at 03:47:31PM +0100, Matthew Garrett wrote:
> On Wed, Sep 27, 2006 at 12:20:29AM -0400, Dave Jones wrote:
>
> > Good question. There's no real replacement for pm_active in the non-legacy
> > config afaik. Perhaps the cleanest alternative is to undeprecate that macro?
> > The only other option I can think of is doing something like this in apm.c ...
> >
> > +#ifdef CONFIG_ACPI
> > - if (PM_IS_ACTIVE()) {
> > printk(KERN_NOTICE "apm: overridden by ACPI.\n");
> > apm_info.disabled = 1;
> > return -ENODEV;
> > - }
> > +#endif
>
> That's not a good choice - it needs to be a runtime check, not a
> compile-time one. Don't we have an acpi_enabled() function?
You're right, the above would break if booted with acpi=off.
Hmm.
Dave
prev parent reply other threads:[~2006-09-27 17:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060927024628.GA29182@redhat.com>
2006-09-27 4:00 ` T30 boot hang with CONFIG_PM_LEGACY=n Len Brown
2006-09-27 4:20 ` Dave Jones
2006-09-27 14:47 ` Matthew Garrett
2006-09-27 17:15 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060927171512.GF997@redhat.com \
--to=davej@redhat.com \
--cc=jeff@garzik.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.osdl.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox