From: Pavel Machek <pavel@ucw.cz>
To: Heikki Orsila <shd@zakalwe.fi>
Cc: "Eugeny S. Mints" <eugeny.mints@gmail.com>,
linux-pm@lists.osdl.org, linux-kernel@vger.kernel.org,
ext-Tuukka.Tikkanen@nokia.com
Subject: Re: [linux-pm] [RFC] OMAP1 PM Core, PM Core Implementation 2/2
Date: Sun, 1 Oct 2006 19:10:32 +0200 [thread overview]
Message-ID: <20061001171032.GE2254@elf.ucw.cz> (raw)
In-Reply-To: <20061001152228.GA24539@zakalwe.fi>
On Sun 2006-10-01 18:22:28, Heikki Orsila wrote:
> Some nitpicking about the patch follows..
>
> On Sat, Sep 30, 2006 at 02:24:35AM +0400, Eugeny S. Mints wrote:
> > +static long
> > +get_vtg(const char *vdomain)
> > +{
> > + long ret = 0;
>
> Unnecessary initialisation.
No, sorry.
> > +static long
> > +set_vtg(const char *vdomain, int val)
> > +{
> > + long ret = 0;
>
> here too. This and 'int i = 0;' happens in many functions.
Wrong again. automatic variables are not zero initialized.
> > + err = omap_pm_core_verify_opt(opt);
> > + if (err != 0)
> > + goto out;
> > +
> > + return (void *)opt;
> > +out:
> > + kfree(opt);
> > + return NULL;
> > +}
>
> Maybe use if (err != 0) { kfree(opt); return NULL; } because goto out is
> only used once?
This is actually common kernel idiom, so it is okay to leave like
this. Your other points are ok.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2006-10-01 17:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-29 22:24 [RFC] OMAP1 PM Core, PM Core Implementation 2/2 Eugeny S. Mints
2006-10-01 15:22 ` Heikki Orsila
2006-10-01 17:10 ` Pavel Machek [this message]
2006-10-01 17:32 ` Heikki Orsila
2006-10-01 17:37 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2006-10-02 18:58 [linux-pm] " Scott E. Preece
2006-10-02 20:44 ` Heikki Orsila
2006-10-04 21:24 ` Pavel Machek
2006-10-02 19:19 Scott E. Preece
2006-10-02 21:53 Scott E. Preece
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061001171032.GE2254@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=eugeny.mints@gmail.com \
--cc=ext-Tuukka.Tikkanen@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.osdl.org \
--cc=shd@zakalwe.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox