public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
Cc: Linus Torvalds <torvalds@osdl.org>, Pavel Machek <pavel@ucw.cz>,
	Andrew Morton <akpm@osdl.org>,
	linux-acpi@vger.kernel.org, linux-pm@osdl.org,
	linux-pm@lists.osdl.org
Subject: Re: [linux-pm] [RFC] ACPI vs device ordering on resume
Date: Fri, 1 Dec 2006 10:40:40 -0800	[thread overview]
Message-ID: <20061201104040.7e936bb9@freekitty> (raw)
In-Reply-To: <45706A4F.6090200@linux.intel.com>

On Fri, 01 Dec 2006 20:45:51 +0300
Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com> wrote:

> Linus Torvalds wrote:
> > On Fri, 1 Dec 2006, Pavel Machek wrote:
> >
> >   
> >>>> So it looks like we need this sequence:
> >>>>
> >>>> enable_nonboot_cpus() /* INIT */
> >>>> finish()	/* _WAK */
> >>>> device_resume()
> >>>>         
> >>> Can somebody remind me about this immediately after 2.6.19?
> >>>       
> >> Remind. But note that freezer is not yet SMP safe... Rafael is working
> >> on that.
> >>     
> >
> > Thanks.
> >
> > On the other hand, I really wonder (and suspect) whether the problem isn't 
> > really the freezer or even the kernel resume ordering, but simply an ACPI 
> > internal resume ordering thing.
> >
> > Doesn't ACPI have per-device "WAK" calls anyway? Shouldn't we just call 
> > those _individually_ as we walk the device tree (perhaps in the 
> > "early_resume" stage) rather than calling them all in one chunk?
> >
> > 		Linus
> >   
> _WAK method is system-wide. Individual objects do not have their own 
> resume methods.
> One way of reordering internal ACPI resume is done in patch series to 
> 7122, I mentioned that earlier.
> It's possible to resume ACPI devices after execution of _WAK in pm->finish.

Does it solve the original problem where finish() was getting run after
device_resume(), and finish() was corrupting PCI register settings like
MSI?


-- 
Stephen Hemminger <shemminger@osdl.org>

  reply	other threads:[~2006-12-01 18:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-14 23:30 [RFC] ACPI vs device ordering on resume Stephen Hemminger
2006-11-14 23:59 ` Linus Torvalds
2006-11-15  7:03 ` [linux-pm] " Len Brown
2006-11-15  9:32   ` Rafael J. Wysocki
2006-11-15 16:47   ` Linus Torvalds
2006-12-01  9:33     ` Pavel Machek
2006-12-01 10:33       ` Rafael J. Wysocki
2006-12-01 10:57         ` Pavel Machek
2006-12-01 11:31           ` Rafael J. Wysocki
2006-12-01 16:12       ` Linus Torvalds
2006-12-01 17:45         ` Alexey Starikovskiy
2006-12-01 18:40           ` Stephen Hemminger [this message]
2006-12-01 18:42             ` Alexey Starikovskiy
2006-12-01  1:48   ` Stephen Hemminger
2006-12-01 10:25     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061201104040.7e936bb9@freekitty \
    --to=shemminger@osdl.org \
    --cc=akpm@osdl.org \
    --cc=alexey.y.starikovskiy@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=linux-pm@osdl.org \
    --cc=pavel@ucw.cz \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox