From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [linux-pm] [RFC][PATCH -mm 1/5] PM: Make freeze_processes SMP-safe Date: Sat, 2 Dec 2006 11:55:13 +0000 Message-ID: <20061202115512.GB4030@ucw.cz> References: <200612012057.01658.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: suspend-devel-bounces@lists.sourceforge.net Errors-To: suspend-devel-bounces@lists.sourceforge.net To: Alan Stern Cc: "Rafael J. Wysocki" , suspend-devel@lists.sourceforge.net, pm list List-Id: linux-pm@vger.kernel.org Hi! > > We send fake signals to them, so they enter get_signal_to_deliver() and they > > call try_to_freeze() from there. > > Well then, see, you're doing exactly what you said should never happen -- > you are freezing a user thread while it might be holding a lock that the > unfreezable usb-storage thread needs. I do not think it is okay to call get_signal_to_deliver with *any* lock held... Or do you have example when that is broken? Pavel -- Thanks for all the (sleeping) penguins. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV