From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH -mm 1/2]: PM: Fix handling of stopped
	tasks
Date: Sat, 9 Dec 2006 16:35:32 +0100
Message-ID: <200612091635.33455.rjw@sisk.pl>
References: <200612032318.29030.rjw@sisk.pl> <200612082307.07305.rjw@sisk.pl>
	<20061208233619.GB25223@elf.ucw.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <suspend-devel-bounces@lists.sourceforge.net>
In-Reply-To: <20061208233619.GB25223@elf.ucw.cz>
Content-Disposition: inline
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/suspend-devel>,
	<mailto:suspend-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=suspend-devel>
List-Post: <mailto:suspend-devel@lists.sourceforge.net>
List-Help: <mailto:suspend-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/suspend-devel>,
	<mailto:suspend-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: suspend-devel-bounces@lists.sourceforge.net
Errors-To: suspend-devel-bounces@lists.sourceforge.net
To: Pavel Machek <pavel@suse.cz>
Cc: suspend-devel@lists.sourceforge.net, pm list <linux-pm@lists.osdl.org>, Stephen Hemminger <shemminger@osdl.org>, Nigel Cunningham <ncunningham@linuxmail.org>
List-Id: linux-pm@vger.kernel.org

Hi,

On Saturday, 9 December 2006 00:36, Pavel Machek wrote:
> Hi!
> 
> > > > I wonder if we should start a test suite ;-).
> > > > 
> > > > > This means, however, that with this patch the behavior of a process (gdb)
> > > > > after the resume may be different to its normal behavior, which is wrong.
> > > > 
> > > > Yep.
> > 
> > Okay, I think I know what to do so that it works.  The above symptoms are not
> > present with the appended patch.
> 
> Looks good to me. Thanks for you work!

Well, there's still a race possible in there, if SIGCONT comes after we have
forced the SIGSTOP and before we call signal_wake_up().

I think we should force the SIGSTOP and call signal_wake_up() without
releasing the lock.  I'll try to do something along these lines later today.

Greetings,
Rafael


-- 
If you don't have the time to read,
you don't have the time or the tools to write.
		- Stephen King

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV