From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH -mm 1/2]: PM: Fix handling of stopped tasks Date: Sun, 10 Dec 2006 21:00:02 +0100 Message-ID: <20061210200002.GA32578@elf.ucw.cz> References: <200612032318.29030.rjw@sisk.pl> <200612091635.33455.rjw@sisk.pl> <200612100127.37288.rjw@sisk.pl> <200612101145.37342.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <200612101145.37342.rjw@sisk.pl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: suspend-devel-bounces@lists.sourceforge.net Errors-To: suspend-devel-bounces@lists.sourceforge.net To: "Rafael J. Wysocki" Cc: suspend-devel@lists.sourceforge.net, pm list , Stephen Hemminger , Nigel Cunningham List-Id: linux-pm@vger.kernel.org Hi! > Ah, freeze(p) need not be under the lock. > > Besides, I'm now thinking the previous version is also correct, because even > if SIGCONT comes after we have forced SIGSTOP, it will remove the SIGSTOP > from the queue and the task's state will change to TASK_RUNNING, so the > next signal_wake_up() will do what it should. > > I prefer that one, because it's shorter and doesn't affect sched.h. ;-) Okay... consider your latest patches ACKed. (But it would be nice to make them wait in -mm to 2.6.21, I believe this needs testing). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV