From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: pm list <linux-pm@lists.osdl.org>
Cc: suspend-devel List <suspend-devel@lists.sourceforge.net>,
linux-acpi@vger.kernel.org, Stefan Seyfried <seife@suse.de>,
Stephen Hemminger <shemminger@osdl.org>,
Pavel Machek <pavel@ucw.cz>
Subject: [PATCH -mm] PM: Change ordering of suspend and resume code
Date: Sun, 17 Dec 2006 18:58:15 +0100 [thread overview]
Message-ID: <200612171858.16380.rjw@sisk.pl> (raw)
Hi,
As indicated in a recent thread on Linux-PM, it's necessary to call
pm_ops->finish() before devce_resume(), but enable_nonboot_cpus() has to be
called before pm_ops->finish()
(cf. http://lists.osdl.org/pipermail/linux-pm/2006-November/004164.html).
For consistency, it seems reasonable to call disable_nonboot_cpus() after
device_suspend().
This way the suspend code will remain symmetrical with respect to the resume
code and it may allow us to speed up things in the future by suspending and
resuming devices and/or saving the suspend image in many threads.
The following series of patches reorders the suspend and resume code so that
nonboot CPUs are disabled after devices have been suspended and enabled before
the devices are resumed. It also causes pm_ops->finish() to be called after
enable_nonboot_cpus() wherever necessary.
The first patch changes the ordering of the suspend-to-RAM code and is
untested, because my boxes continue refusing to resume from RAM for other
reasons. If anyone can, please do me a favour and test it.
The second patch changes the ordering of the built-in suspend-to-disk code,
and the last two patches modify the swsusp userland interface code
accordingly. As far as the last patch is concerned, I've decided to change
the existing ioctls, so that the patched kernel works with the "old" userland.
I don't think this change breaks anything of importance, but if it does, we
can just add (yet) another ioctl to set the platform mode, although in that
case the userland would have to be changed as well.
All of the patches are against 2.6.20-rc1 and should not be used with any
earlier kernel.
Greetings,
Rafael
--
If you don't have the time to read,
you don't have the time or the tools to write.
- Stephen King
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
next reply other threads:[~2006-12-17 17:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-17 17:58 Rafael J. Wysocki [this message]
2006-12-17 18:02 ` [PATCH -mm 1/4] PM: Change code ordering in main.c Rafael J. Wysocki
2006-12-17 18:05 ` [PATCH -mm 2/4] swsusp: Change code ordering in disk.c Rafael J. Wysocki
2006-12-17 18:09 ` [PATCH -mm 3/4] swsusp: Change code ordering in user.c Rafael J. Wysocki
2006-12-17 18:18 ` [PATCH -mm 4/4] swsusp: Change pm_ops handling by userland interface Rafael J. Wysocki
2006-12-18 7:42 ` [PATCH -mm] PM: Change ordering of suspend and resume code Stefan Seyfried
2006-12-18 15:10 ` Rafael J. Wysocki
2006-12-19 23:30 ` Pavel Machek
2006-12-20 12:43 ` [Suspend-devel] " Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612171858.16380.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.osdl.org \
--cc=pavel@ucw.cz \
--cc=seife@suse.de \
--cc=shemminger@osdl.org \
--cc=suspend-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox