Re: [PATCH 03/10] powerpc: fix comment in kernel/irq.c

Benjamin Herrenschmidt
2007-02-05T22:59:36Z

On Mon, 2007-02-05 at 19:30 +0100, Johannes Berg wrote:
> plain text document attachment (irq-comment.patch)
> kernel/irq.c contains a comment that speaks of -1 and -2 as interrupt
> numbers. Replace by NO_IRQ and NO_IRQ_IGNORE.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> Cc: Andrew Morton <akpm@osdl.org>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> --- mb-wireless.orig/arch/powerpc/kernel/irq.c 2007-02-05 14:24:06.694526864 +0100
> +++ mb-wireless/arch/powerpc/kernel/irq.c 2007-02-05 14:24:37.084526864 +0100
> @@ -281,10 +281,10 @@ void do_IRQ(struct pt_regs *regs)
>
> /*
> * Every platform is required to implement ppc_md.get_irq.
> - * This function will either return an irq number or -1 to
> + * This function will either return an irq number or NO_IRQ to
> * indicate there are no more pending.
> - * The value -2 is for buggy hardware and means that this IRQ
> - * has already been handled. -- Tom
> + * The value NO_IRQ_IGNORE is for buggy hardware and means that this
> + * IRQ has already been handled. -- Tom
> */
> irq = ppc_md.get_irq();
>
>
> --
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev