Re: [PATCH 05/10] powermac: generic time suspend/resume code

Guennadi Liakhovetski
2007-02-19T23:19:25Z

On Mon, 19 Feb 2007, Guennadi Liakhovetski wrote:

> On Mon, 5 Feb 2007, Johannes Berg wrote:
>
> > This patch removes the time suspend/restore code that was done through
> > a PMU notifier in arch/platforms/powermac/time.c.
> >
> > Instead, we introduce arch/powerpc/sysdev/timer.c which creates a sys
> > device and handles time of day suspend/resume through that.
>
> I think there's a problem with this one. In my tests with this patch the
> system time is incremented twice, so, looks like some code already takes
> care about that. Maybe there's some very indirect code in generic rtc, but
> I haven't found anything yet. Anyway, requires more investigation and,
> probably, should not be included before we clarify this.

Ok, it has been a problem with my testing. ATM I don't know of any
problems with it, so, please, consider my objections void.

Thanks
Guennadi
---
Guennadi Liakhovetski