[RFC 10/10] powermac: fix G5-cpufreq for cpu on/offline

Johannes Berg
2007-02-05T18:30:37Z

[-- Attachment #1: powermac-fix-cpufreq.patch --]
[-- Type: text/plain, Size: 1422 bytes --]

The original code here is wrong, it applies "previous" knowledge.
The way the cpufreq core is designed is that the policy for the
secondary CPU that comes online says that it must in fact not
use this policy but use the same as the other CPUs that are
listed, which in fact is CPU#0.

Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: cpufreq list <cpufreq@lists.linux.org.uk>
Cc: Jacob Shin <jacob.shin@amd.com>

---
Not tested yet but from what Jacob said this should work.

--- mb-wireless.orig/arch/powerpc/platforms/powermac/cpufreq_64.c 2007-02-05 18:41:35.414524763 +0100
+++ mb-wireless/arch/powerpc/platforms/powermac/cpufreq_64.c 2007-02-05 19:08:53.994524763 +0100
@@ -357,13 +357,13 @@ static unsigned int g5_cpufreq_get_speed

static int g5_cpufreq_cpu_init(struct cpufreq_policy *policy)
{
- if (policy->cpu != 0)
- return -ENODEV;
-
policy->governor = CPUFREQ_DEFAULT_GOVERNOR;
policy->cpuinfo.transition_latency = CPUFREQ_ETERNAL;
policy->cur = g5_cpu_freqs[g5_query_freq()].frequency;
- policy->cpus = cpu_possible_map;
+ /* secondary CPUs are tied to the primary one by the
+ * cpufreq core if in the secondary policy we tell it that
+ * it actually must be one policy together with all others. */
+ policy->cpus = cpu_online_map;
cpufreq_frequency_table_get_attr(g5_cpu_freqs, policy->cpu);

return cpufreq_frequency_table_cpuinfo(policy,

--