Re: [RFC 08/10] powerpc: dart iommu suspend

Johannes Berg
2007-02-07T11:42:58Z

[-- Attachment #1.1: Type: text/plain, Size: 949 bytes --]

On Tue, 2007-02-06 at 13:40 +0100, Pavel Machek wrote:

> > + SetPageNosave(virt_to_page((void*)((unsigned long)dart_tablebase + i)));
> > +
>
> 80 columns rule?

Good point. Changed according to Olof's comment anyway so it should be
shorter now.

> > --- mb-wireless.orig/include/asm-powerpc/iommu.h 2007-02-05 14:24:05.014526864 +0100
> > +++ mb-wireless/include/asm-powerpc/iommu.h 2007-02-05 14:24:40.684526864 +0100
> > @@ -108,6 +108,10 @@ static inline void pci_iommu_init(void)
> > #endif
> >
> > extern void alloc_dart_table(void);
> > +#if defined(CONFIG_SOFTWARE_SUSPEND) && defined(CONFIG_U3_DART)
> > +extern void iommu_dart_save(void);
> > +extern void iommu_dart_restore(void);
> > +#endif
>
> You can go without the ifdef; extra prototype does not do any harm.

Changed as well anyway to introduce powerpc iommu suspend ops, though I
introduced two static inlines that are still ifdefed.

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]