Re: [PATCH 02/12] powermac: support G5 CPU hotplug

Johannes Berg
2007-02-08T15:38:19Z

[-- Attachment #1.1: Type: text/plain, Size: 602 bytes --]

On Thu, 2007-02-08 at 14:28 +0100, Johannes Berg wrote:
>
> +#ifdef CONFIG_CPU_HOTPLUG
> + /* if we have fake CPU hotplug just to support suspend to disk
> + * and can't really turn off a CPU, it may be taking timer interrupts
> + * even when it is dead. Avoid doing anything in that case so global
> + * state is not modified for and by a CPU that doesn't really exist. */
> + if (__get_cpu_var(cpu_state) == CPU_DEAD)
> + return;
> +#endif

Michael Buesch suggested to add an unlikely() there which I'll do for
the next round.

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]