Re: [PATCH 05/12] power management: no valid states w/o pm_ops + docs

Johannes Berg
2007-02-13T16:08:40Z

[-- Attachment #1.1: Type: text/plain, Size: 907 bytes --]

On Tue, 2007-02-13 at 13:12 +0100, Pavel Machek wrote:
> Hi!
>
> > This patch changes /sys/power/state to not advertise any valid states
> > (except for disk if SOFTWARE_SUSPEND is enabled) when no pm_ops have been
> > set so userspace can easily discover what states should be available.
> >
> > Also, because the pm ops in powermac are obviously not using them as
> > intended, I added documentation for it in kernel-doc format.
> >
> > Reordering the fields in struct pm_ops not only makes the output of
> > kernel-doc make more sense but also removes a hole from the structure on
> > 64-bit platforms.
> >
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> > Cc: linux-pm@lists.osdl.org
> > Cc: Rafael J. Wysocki <rjw@sisk.pl>
> > Cc: Pavel Macheck <pavel@ucw.cz>
>
> Looks okay to me.

Are you going to pick it up or should I send it to someone else?

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]