Re: [PATCH 02/12] powermac: support G5 CPU hotplug

Johannes Berg
2007-02-15T15:08:28Z

[-- Attachment #1.1: Type: text/plain, Size: 1003 bytes --]

On Thu, 2007-02-15 at 14:44 +1100, Paul Mackerras wrote:

> > +_GLOBAL(power4_idle_irqs_softdisabled)
> > + li r6,1
> > + b 0f
> > _GLOBAL(power4_idle)
> > + li r6,0
> > +0:
> > BEGIN_FTR_SECTION
> > blr
> > END_FTR_SECTION_IFCLR(CPU_FTR_CAN_NAP)
> > @@ -35,8 +40,8 @@ END_FTR_SECTION_IFCLR(CPU_FTR_CAN_NAP)
> > rotldi r0,r0,16
> > mtmsrd r0,1 /* hard-disable interrupts */
> > li r0,1
> > - stb r0,PACASOFTIRQEN(r13) /* we'll hard-enable shortly */
> > - stb r0,PACAHARDIRQEN(r13)
> > + stb r0,PACAHARDIRQEN(r13) /* we'll hard-enable shortly */
> > + stb r6,PACASOFTIRQEN(r13) /* set softirqs enabled bit */
>
> Don't you have something backwards here? If we come in through
> power4_idle_irqs_softdisabled, the name would indicate to me that we
> want to end up with paca->soft_enabled set to 0, not 1.

Umm, yes, looks like. I'll rewrite it. Interesting that it worked as I
had expected though (I actually put a printk into the timer interrupt!).

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

[-- Attachment #2: Type: text/plain, Size: 146 bytes --]

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org