Re: [PATCH 13/12] mpic: add affinity callback for IPI "chip"

Johannes Berg
2007-02-09T15:41:08Z

[-- Attachment #1.1: Type: text/plain, Size: 683 bytes --]

On Fri, 2007-02-09 at 08:14 +1100, Benjamin Herrenschmidt wrote:
>
> > This patch adds a dummy affinity callback for the IPI "chip" to avoid
> > getting a warning ("Cannot set affinity for irq 251") when taking a
> > CPU offline via sysfs or during suspend.
>
> Wouldn't be a better option to make sure they have IRQF_PERCPU set and
> that we don't do the affinity thing on interrupts with that flag when
> offlining a CPU ?

Hmm. Yeah, something like that could be possible. Looking at
fixup_irqs() there is a test:

if (irq_desc[irq].status & IRQ_PER_CPU)
continue;

but I'd have to dig what else this means.

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]