Re: [PATCH] Re: NAK new drivers without proper power management?

Matthew Garrett
2007-02-11T12:13:40Z

On Sun, Feb 11, 2007 at 07:54:04AM +0100, Willy Tarreau wrote:

> instead of modifying all drivers to explicitly state that they don't support
> it, we should start with a test of the NULL pointer for .suspend which should
> mean exactly the same without modifying the drivers. I find it obvious that
> a driver which does provide a suspend function will not support it. And if
> some drivers (eg /dev/null) can support it anyway, it's better to change
> *those* drivers to explicitly mark them as compatible.

No, that doesn't work. In the absence of suspend/resume methods, the PCI
layer will implement basic PM itself. In some cases, this works. In
others, it doesn't. There's no way to automatically determine which is
which without modifying the drivers.

--
Matthew Garrett | mjg59@srcf.ucam.org