Re: [PATCH] Re: NAK new drivers without proper power management?

Rafael J. Wysocki
2007-02-10T09:34:03Z

Hi,

On Saturday, 10 February 2007 04:02, Nigel Cunningham wrote:
> Hi.
>
> On Fri, 2007-02-09 at 19:50 -0600, Robert Hancock wrote:
> > It also kind of bothers me that if a driver has no suspend/resume
> > functions, and you suspend and resume the system, we don't complain
> > about it even though there's a very good chance that device is not going
> > to function properly. How about something in dmesg like:
> >
> > Warning: driver for device XXXX has no suspend or resume support.
> > Device may not function properly after resume.
> >
> > so that users know who to complain to. Maybe there are some devices that
> > truly don't need any handling for suspend, but if so I suspect the
> > number of those is small enough that adding empty functions would be a
> > good-enough solution.
>
> Here's my current version of a patch to do this, if anyone wants to try
> it out. It dumps stack with the warning to make it easier to see what
> the source of the message is:

I have an alternative idea.

There is a test mode of swsusp that's triggered with
"echo test > /sys/power/disk" and "echo disk > /sys/power/state". We can make
it set a switch that will be used to trigger the warnings in the core.

This way the warnings will only appear in the user's dmesg in the test mode
and not always.

Would that be acceptable?

Rafael