Re: [PATCH] Re: NAK new drivers without proper power management?

Matthew Garrett
2007-02-11T13:19:57Z

On Sun, Feb 11, 2007 at 02:09:43PM +0100, Willy Tarreau wrote:

> Then change the PCI layer to do the basic PM only for known compatible
> drivers, and modify only the known-compatible drivers to mark them
> explicitly compatible. IMHO, it generally is a bad idea to require that
> any driver explicitly states what it *does not* support. It's the reason
> why users encounter problem on new features with old drivers. For instance,
> do you know if the old ISA NE2000 driver breaks suspend ? I don't know,
> but I would at least expect it not to support it by default. It's best
> to announce what *is* supported and consider everything unimplemented
> otherwise explicitly stated.

This ignores the reality of the situation, which is that many drivers
support suspend and resume despite the lack of any explicit
implementation. Changing things so they're flagged as broken when
they're not would be a regression.

--
Matthew Garrett | mjg59@srcf.ucam.org