Re: [PATCH] Re: NAK new drivers without proper power management?

Nigel Cunningham
2007-02-11T23:06:06Z

Hi.

On Sun, 2007-02-11 at 19:53 +0100, Rafael J. Wysocki wrote:
> > Having drivers explicitly marked as to whether they are safe is a good kernel
> > feature; what to do if they're not is policy.
>
> That's true, but I assume that the people who opt for doing that are also
> willing to take part in the review of the drivers. :-)

Absolutely :)

> Well, I don't think so. Let's estimate the number of drivers that define
> .resume() right now:
>
> $ grep -I -l -r '.resume =' linux-2.6.20/drivers/ | wc
> 102 102 4169

I think the '.resume =' doesn't help - some have tabs. I ran '\.resume'
and got 351.

It would be interesting to see how many struct pci_driver etc instances
lack resume methods.

Regards,

Nige