Re: [PATCH] Re: NAK new drivers without proper power management?

Robert Hancock
2007-02-11T17:36:53Z

Matthew Garrett wrote:
> On Sun, Feb 11, 2007 at 07:54:04AM +0100, Willy Tarreau wrote:
>
>> instead of modifying all drivers to explicitly state that they don't support
>> it, we should start with a test of the NULL pointer for .suspend which should
>> mean exactly the same without modifying the drivers. I find it obvious that
>> a driver which does provide a suspend function will not support it. And if
>> some drivers (eg /dev/null) can support it anyway, it's better to change
>> *those* drivers to explicitly mark them as compatible.
>
> No, that doesn't work. In the absence of suspend/resume methods, the PCI
> layer will implement basic PM itself. In some cases, this works. In
> others, it doesn't. There's no way to automatically determine which is
> which without modifying the drivers.
>

The only thing that the PCI layer does for PM is the stuff that the
driver would normally tell the PCI layer to do as part of a proper
suspend/resume implementation: enable/disable the device and
save/restore the PCI configuration space (only the standardized part, I
believe). This is the bare minimum that's needed on all PCI devices,
whether or not they even have a driver loaded. I suspect the number of
PCI devices where this is truly all they need, i.e. no state in any IO
ports or MMIO registers that need to be reset on resume, is quite low.
Maybe in some cases it may appear to work by luck, i.e. the registers
happening to be set to the correct values (especially on
suspend-to-disk) but this is not a proper implementation.

--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/