From: Tejun Heo <htejun@gmail.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Alan <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org, jgarzik@pobox.com,
linux-pm@lists.osdl.org, linux-ide@vger.kernel.org,
stable@kernel.org
Subject: [PATCH 1/2 -stable] libata: add missing PM callbacks
Date: Fri, 2 Mar 2007 17:45:30 +0900 [thread overview]
Message-ID: <20070302084530.GN20322@htj.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.60.0703012305030.7351@poirot.grange>
Some LLDs were missing scsi device PM callbacks while having host/port
suspend support. Add missing ones.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
This should fix the problem you're seeing on sil680. These patches
are against 2.6.20.1. Patches for libata-dev#upstream is separately
posted to linux-ide in the following thread.
http://thread.gmane.org/gmane.linux.ide/16475
drivers/ata/pata_jmicron.c | 4 ++++
drivers/ata/pata_sil680.c | 4 ++++
2 files changed, 8 insertions(+)
Index: work1/drivers/ata/pata_sil680.c
===================================================================
--- work1.orig/drivers/ata/pata_sil680.c
+++ work1/drivers/ata/pata_sil680.c
@@ -226,6 +226,10 @@ static struct scsi_host_template sil680_
.slave_configure = ata_scsi_slave_config,
.slave_destroy = ata_scsi_slave_destroy,
.bios_param = ata_std_bios_param,
+#ifdef CONFIG_PM
+ .suspend = ata_scsi_device_suspend,
+ .resume = ata_scsi_device_resume,
+#endif
};
static struct ata_port_operations sil680_port_ops = {
Index: work1/drivers/ata/pata_jmicron.c
===================================================================
--- work1.orig/drivers/ata/pata_jmicron.c
+++ work1/drivers/ata/pata_jmicron.c
@@ -137,6 +137,10 @@ static struct scsi_host_template jmicron
.slave_destroy = ata_scsi_slave_destroy,
/* Use standard CHS mapping rules */
.bios_param = ata_std_bios_param,
+#ifdef CONFIG_PM
+ .suspend = ata_scsi_device_suspend,
+ .resume = ata_scsi_device_resume,
+#endif
};
static const struct ata_port_operations jmicron_ops = {
next prev parent reply other threads:[~2007-03-02 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061122172841.0b90f042@localhost.localdomain>
[not found] ` <Pine.LNX.4.60.0702262150460.5079@poirot.grange>
2007-02-28 21:19 ` [PATCH] pata_sil680 suspend/resume Guennadi Liakhovetski
2007-03-01 22:11 ` Guennadi Liakhovetski
2007-03-02 8:45 ` Tejun Heo [this message]
2007-03-02 8:46 ` [PATCH 2/2 -stable] libata: add missing CONFIG_PM in LLDs Tejun Heo
2007-03-03 0:18 ` Nigel Cunningham
2007-03-03 3:20 ` [linux-pm] " Tejun Heo
2007-03-03 5:34 ` Nigel Cunningham
2007-03-02 22:42 ` [PATCH 1/2 -stable] libata: add missing PM callbacks Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070302084530.GN20322@htj.dyndns.org \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=g.liakhovetski@gmx.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.osdl.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox