Re: [linux-pm] [3/6] 2.6.21-rc4: known regressions

David Brownell
2007-03-28T21:17:36Z

On Wednesday 28 March 2007 1:42 pm, Linus Torvalds wrote:
>
> I won't disagree - it might well be much nicer to just show it in the
> "real" device tree. I'm not 100% sure where in the tree it would go,
> though. It should probably be "inside" the root entry, before any of the
> PCI buses.

Mixing "inside" and "before" is a small linguistic clue about
one of the issues with driver model PM. Off topic here; and
in terms of suspend/resume callback sequencing that answer
shouldn't matter much for HPET (as I understand things).

> It's generally what we've used those "system device" things
> for, but I agree that it would be better to just make system devices show
> up early on the regular device list than it is to have them be special
> cases.

Yes -- where "platform_device" is a regular Joe-Sixpack kind of
device, but "sysdev" is a special case.

> Bit I think that's a separate (and fairly small) issue compared to the
> "don't use the clocksource infrastructure as a make-believe suspend/resume
> mechanism" problem that Maxim's patch had.

Agreed -- although isn't it the "clockevent" change which is at issue?

A "clockevent" thingie wraps various kinds of timer IRQs; the clocksource
is conceptually just a free run counter. Clocksources have been around
for a while, with no particular problems.

It's clockevent sources have been the problem with dynamic tick solutions
all along, since they mask such chaos inside x86 hardware and interact
with so many different parts of the kernel. ;)

- Dave

> (Maxim, don't take that the wrong way - I think your analysis and patch
> were great, I just think another organization would be better)