From: David Brownell <david-b@pacbell.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: Alexey Starikovskiy <alexey.y.starikovskiy@intel.com>,
Dirk Behme <dirk.behme@de.bosch.com>,
linux-pm@lists.osdl.org, Ben Dooks <ben@simtec.co.uk>,
Johannes Berg <johannes@sipsolutions.net>,
Nicolas Pitre <nico@cam.org>
Subject: Re: [PATCH] add firmware disk state and clean up
Date: Tue, 20 Mar 2007 16:31:13 -0700 [thread overview]
Message-ID: <200703201631.14245.david-b@pacbell.net> (raw)
In-Reply-To: <20070320220946.GL3545@elf.ucw.cz>
On Tuesday 20 March 2007 3:09 pm, Pavel Machek wrote:
> Hi!
>
> > > +static int at91_pm_valid(suspend_state_t state)
> > > +{
> > > + return state == PM_SUSPEND_MEM;
> > > +}
> > >
> > > static struct pm_ops at91_pm_ops ={
> > > .valid = at91_pm_valid_state,
^^^^^
> > > .prepare = at91_pm_prepare,
> > > .enter = at91_pm_enter,
> > > + .valid = at91_pm_valid,
^^^^^
> > > };
> > >
> > > static int __init at91_pm_init(void)
> >
> > Clearly bogus. The STR support isn't upstream yet, true, but
>
> No... look again.
No, YOU look again. If that compiles, it's a GCC bug.
> This tries to disable suspend-to-disk on ARM, so
> that only suspend-to-RAM is enabled. I'd not call it bogus.
>
> The series is needed to stop pm from reporting "platform" on ARM;
> "platform" only makes sense on ACPI systems.
>
> Pavel
next prev parent reply other threads:[~2007-03-20 23:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070320015821.782406000@sipsolutions.net>
2007-03-20 1:58 ` [PATCH] rework pm_ops pm_disk_modes foo Johannes Berg
2007-03-20 8:46 ` [PATCH v2] " Johannes Berg
2007-03-20 9:31 ` Pavel Machek
2007-03-20 9:36 ` Johannes Berg
2007-03-20 9:43 ` Pavel Machek
2007-03-20 9:46 ` Johannes Berg
2007-03-20 10:17 ` [PATCH] add firmware disk state and clean up Johannes Berg
2007-03-20 10:25 ` Pavel Machek
2007-03-20 10:45 ` Johannes Berg
2007-03-20 11:02 ` [PATCH] remove firmware disk mode Johannes Berg
2007-03-20 13:15 ` Pavel Machek
2007-03-20 11:06 ` [PATCH] implement pm_ops.valid for everybody Johannes Berg
2007-03-20 13:16 ` Pavel Machek
2007-03-20 23:44 ` David Brownell
2007-03-20 22:49 ` Pavel Machek
2007-03-21 21:01 ` Guennadi Liakhovetski
2007-03-21 22:07 ` David Brownell
2007-03-21 22:36 ` Guennadi Liakhovetski
2007-03-21 22:57 ` Pavel Machek
2007-03-21 23:25 ` David Brownell
2007-03-21 23:31 ` Pavel Machek
2007-03-22 10:03 ` Johannes Berg
2007-03-22 17:10 ` David Brownell
2007-03-22 17:18 ` Johannes Berg
2007-03-22 18:13 ` David Brownell
2007-03-22 18:18 ` Johannes Berg
2007-03-21 23:32 ` Rafael J. Wysocki
2007-03-20 22:59 ` [PATCH] add firmware disk state and clean up David Brownell
2007-03-20 22:09 ` Pavel Machek
2007-03-20 23:31 ` David Brownell [this message]
2007-03-20 11:48 ` [PATCH] rework pm_ops pm_disk_modes foo Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703201631.14245.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=alexey.y.starikovskiy@intel.com \
--cc=ben@simtec.co.uk \
--cc=dirk.behme@de.bosch.com \
--cc=johannes@sipsolutions.net \
--cc=linux-pm@lists.osdl.org \
--cc=nico@cam.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox