From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-pm <linux-pm@lists.osdl.org>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] introduce /sys/power/disk_powerdown_mode
Date: Wed, 21 Mar 2007 13:25:17 +0100 [thread overview]
Message-ID: <200703211325.17696.rjw@sisk.pl> (raw)
In-Reply-To: <1174468981.3769.8.camel@johannes.berg>
On Wednesday, 21 March 2007 10:23, Johannes Berg wrote:
> This patch introduces /sys/power/disk_powerdown_mode
I don't think this name is the right one too, since the platform mode is not
exactly the power down mode (let alone test and testproc).
> and deprecates /sys/power/disk. The former has the advantages
> * a much more expressive name
Well, please choose another name (I'd probably use disk_mode or something
like that, but 'disk' is well-documented, so why change it?).
> * contains all valid modes as well as the selected one
> in a fashion known from the LED subsystem.
Pleases review the documentation under Documentation/power and
Documentation/ABI and update it in accordance with the changes you're making.
Greetings,
Rafael
next prev parent reply other threads:[~2007-03-21 12:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 9:23 [PATCH] introduce /sys/power/disk_powerdown_mode Johannes Berg
2007-03-21 12:25 ` Rafael J. Wysocki [this message]
2007-03-21 12:25 ` Johannes Berg
2007-03-21 12:29 ` Pavel Machek
2007-03-21 12:32 ` Johannes Berg
2007-03-21 13:11 ` Pavel Machek
2007-03-21 13:12 ` Johannes Berg
2007-03-21 13:17 ` Pavel Machek
2007-03-21 14:01 ` Rafael J. Wysocki
2007-03-21 22:08 ` Pavel Machek
2007-03-22 13:13 ` [linux-pm] " Stefan Seyfried
2007-03-22 14:34 ` [PATCH] power management: change /sys/power/disk display Johannes Berg
2007-03-22 21:45 ` Rafael J. Wysocki
2007-03-23 0:05 ` Pavel Machek
2007-03-23 13:48 ` Johannes Berg
2007-03-23 23:46 ` Pavel Machek
2007-03-23 23:53 ` Johannes Berg
2007-03-24 0:14 ` Pavel Machek
2007-03-24 0:16 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703211325.17696.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=johannes@sipsolutions.net \
--cc=linux-pm@lists.osdl.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox