From: Andrew Morton <akpm@linux-foundation.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-pm@lists.linux-foundation.org,
Russell King <rmk@arm.linux.org.uk>
Subject: Re: [PATCH 3/3] power management: implement pm_ops.valid for everybody
Date: Wed, 21 Mar 2007 17:01:13 -0800 [thread overview]
Message-ID: <20070321170113.2c2b4f1f.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070321235154.GE6060@elf.ucw.cz>
On Thu, 22 Mar 2007 00:51:54 +0100 Pavel Machek <pavel@ucw.cz> wrote:
> On Wed 2007-03-21 15:53:31, Johannes Berg wrote:
> > Almost all users of pm_ops only support mem sleep, don't check in .valid
> > and don't reject any others in .prepare so users can be confused if they
> > check /sys/power/state, especially when new states are added (these would
> > then result in s-t-r although they're supposed to be something different).
> >
> > This patch implements a generic pm_valid_only_mem function that is then
> > exported for users and puts it to use in almost all existing pm_ops.
> >
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> > Cc: David Brownell <david-b@pacbell.net>
> > Cc: Pavel Machek <pavel@ucw.cz>
> > Cc: linux-pm@lists.linux-foundation.org
>
> Looks ok to me. ACK. (But I guess it would be nice to cc rmk or
> something, so we don't conflict with his patches etc?)
>
I copied Russell and Paul on all three patches.
prev parent reply other threads:[~2007-03-22 1:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 14:53 [PATCH 0/3] suspend pm_ops cleanup Johannes Berg
2007-03-21 14:53 ` [PATCH 1/3] rework pm_ops pm_disk_mode, kill misuse Johannes Berg
2007-03-21 23:45 ` Pavel Machek
2007-03-21 14:53 ` [PATCH 2/3] power management: remove firmware disk mode Johannes Berg
2007-03-21 23:49 ` Pavel Machek
2007-03-21 14:53 ` [PATCH 3/3] power management: implement pm_ops.valid for everybody Johannes Berg
2007-03-21 23:51 ` Pavel Machek
2007-03-22 1:01 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321170113.2c2b4f1f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox