From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 3/3] power management: implement pm_ops.valid for everybody Date: Wed, 21 Mar 2007 17:01:13 -0800 Message-ID: <20070321170113.2c2b4f1f.akpm@linux-foundation.org> References: <20070321145328.496614000@sipsolutions.net> <20070321145421.918490000@sipsolutions.net> <20070321235154.GE6060@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20070321235154.GE6060@elf.ucw.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Pavel Machek Cc: Johannes Berg , linux-pm@lists.linux-foundation.org, Russell King List-Id: linux-pm@vger.kernel.org On Thu, 22 Mar 2007 00:51:54 +0100 Pavel Machek wrote: > On Wed 2007-03-21 15:53:31, Johannes Berg wrote: > > Almost all users of pm_ops only support mem sleep, don't check in .valid > > and don't reject any others in .prepare so users can be confused if they > > check /sys/power/state, especially when new states are added (these wou= ld > > then result in s-t-r although they're supposed to be something differen= t). > > = > > This patch implements a generic pm_valid_only_mem function that is then > > exported for users and puts it to use in almost all existing pm_ops. > > = > > Signed-off-by: Johannes Berg > > Cc: David Brownell > > Cc: Pavel Machek > > Cc: linux-pm@lists.linux-foundation.org > = > Looks ok to me. ACK. (But I guess it would be nice to cc rmk or > something, so we don't conflict with his patches etc?) > = I copied Russell and Paul on all three patches.