From: Pavel Machek <pavel@ucw.cz>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH 1/3] rework pm_ops pm_disk_mode, kill misuse
Date: Thu, 22 Mar 2007 00:45:54 +0100 [thread overview]
Message-ID: <20070321234554.GC6060@elf.ucw.cz> (raw)
In-Reply-To: <20070321145420.910171000@sipsolutions.net>
Hi!
> The pm_ops.pm_disk_mode is used in totally bogus ways since
> nobody really seems to understand what it actually does.
Well, I believe me and Rafael understand it by now...
> ACPI is the only user left with a non-zero pm_disk_mode.
>
> The patch also sets the default mode to shutdown again, but
> when a new pm_ops is registered its pm_disk_mode is selected
> as default, that way the default stays for ACPI where it is
> apparently required.
Ok.
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> Cc: David Brownell <david-b@pacbell.net>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: linux-pm@lists.linux-foundation.org
ACK, not 2.6.21 material.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-03-21 23:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 14:53 [PATCH 0/3] suspend pm_ops cleanup Johannes Berg
2007-03-21 14:53 ` [PATCH 1/3] rework pm_ops pm_disk_mode, kill misuse Johannes Berg
2007-03-21 23:45 ` Pavel Machek [this message]
2007-03-21 14:53 ` [PATCH 2/3] power management: remove firmware disk mode Johannes Berg
2007-03-21 23:49 ` Pavel Machek
2007-03-21 14:53 ` [PATCH 3/3] power management: implement pm_ops.valid for everybody Johannes Berg
2007-03-21 23:51 ` Pavel Machek
2007-03-22 1:01 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321234554.GC6060@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox