Re: + rework-pm_ops-pm_disk_mode-kill-misuse.patch added to -mm tree

Paul Mundt
2007-03-22T14:24:37Z

On Thu, Mar 22, 2007 at 02:31:17PM +0100, Pavel Machek wrote:
> > > No, once SOFTWARE_SUSPEND is configured there's *no way* to disable it
> > > after the fact via pm_ops. Read valid_state() in kernel/power/main.c.
> >
> > So how does a platform with only flash (and an insufficient amount of
> > flash at that) tell the suspend code that suspend-to-disk is not
> > supported?
>
> Hohum, perhaps it can suspend to SD card? Or perhaps it can suspend
> over network?
>
> Suspend code will properly fail if there's not enough swap space.
>
> ...plus you are allowed to return -EINVAL from arch_prepare_suspend()
> or how is it called.

So then how exactly is this helping anything? It's pointless to have the
sysfs file visible for platforms that are never going to support suspend
to disk, and -EINVAL'ing out in another path is simply moving the
problem.

The platforms already have a good idea of what sort of suspend they can
cope with, and while I don't see anything against allowing other forms of
suspend to be enabled by the users that really want it, forcing it on
everyone because it's a possibility is nonsense.