Re: + rework-pm_ops-pm_disk_mode-kill-misuse.patch added to -mm tree

Russell King
2007-03-22T13:26:23Z

On Thu, Mar 22, 2007 at 11:08:48AM +0100, Johannes Berg wrote:
> No, once SOFTWARE_SUSPEND is configured there's *no way* to disable it
> after the fact via pm_ops. Read valid_state() in kernel/power/main.c.

So how does a platform with only flash (and an insufficient amount of
flash at that) tell the suspend code that suspend-to-disk is not
supported?

> But that's a design decision, once the kernel config allows suspend to
> disk runtime pm_ops have no say in it.

It sounds like it's a very bad design decision. Maybe if you consider
that the entire world is desktop PCs then it might make sense. That
isn't the case though so it doesn't.

Please fix your broken design.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/