Re: + rework-pm_ops-pm_disk_mode-kill-misuse.patch added to -mm tree

Johannes Berg
2007-03-22T15:05:45Z

[-- Attachment #1.1: Type: text/plain, Size: 595 bytes --]

On Thu, 2007-03-22 at 23:24 +0900, Paul Mundt wrote:

> So then how exactly is this helping anything? It's pointless to have the
> sysfs file visible for platforms that are never going to support suspend
> to disk, and -EINVAL'ing out in another path is simply moving the
> problem.

Just another data point as Pavel has replied to all the points raised
already as far as I can tell...

If you have a platform that doesn't allow CONFIG_SOFTWARE_SUSPEND (which
is only suspend to disk) and doesn't have pm_ops either, then you end up
with an empty /sys/power/state file.

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]