Re: + rework-pm_ops-pm_disk_mode-kill-misuse.patch added to -mm tree

Pavel Machek
2007-03-22T10:03:55Z

On Thu 2007-03-22 01:56:14, Andrew Morton wrote:
> On Thu, 22 Mar 2007 09:48:26 +0000 Russell King <rmk@arm.linux.org.uk> wrote:
>
> > On Wed, Mar 21, 2007 at 04:34:13PM -0700, akpm@linux-foundation.org wrote:
> > > It also removes all the arm and sh users that think they can veto suspend to
> > > disk via pm_ops; not so since the user can always do echo shutdown >
> > > /sys/power/disk, they need to find a better way involving Kconfig or such.
> >
> > NAK. There are ARM platforms where suspend to disk doesn't make any
> > sense what so ever.
>
> So they shouldn't offer it in Kconfig?

(I thought this was a mistake, when rmk acked all three in next mail,
but maybe I'm mistaken now?)

Anyway, this patch is good, as it allows interested ARM machines to
really disable suspend-to-disk. What they were doing previously was
not effective.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html