From: Russell King <rmk@arm.linux.org.uk>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Pavel Machek <pavel@ucw.cz>,
Andrew Morton <akpm@linux-foundation.org>,
linux-pm@lists.linux-foundation.org
Subject: Re: + rework-pm_ops-pm_disk_mode-kill-misuse.patch added to -mm tree
Date: Thu, 22 Mar 2007 13:26:23 +0000 [thread overview]
Message-ID: <20070322132622.GD29627@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1174558128.3944.78.camel@johannes.berg>
On Thu, Mar 22, 2007 at 11:08:48AM +0100, Johannes Berg wrote:
> No, once SOFTWARE_SUSPEND is configured there's *no way* to disable it
> after the fact via pm_ops. Read valid_state() in kernel/power/main.c.
So how does a platform with only flash (and an insufficient amount of
flash at that) tell the suspend code that suspend-to-disk is not
supported?
> But that's a design decision, once the kernel config allows suspend to
> disk runtime pm_ops have no say in it.
It sounds like it's a very bad design decision. Maybe if you consider
that the entire world is desktop PCs then it might make sense. That
isn't the case though so it doesn't.
Please fix your broken design.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2007-03-22 13:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 23:34 + rework-pm_ops-pm_disk_mode-kill-misuse.patch added to -mm tree akpm
2007-03-22 9:48 ` Russell King
2007-03-22 9:56 ` Andrew Morton
2007-03-22 10:03 ` Pavel Machek
2007-03-22 10:08 ` Johannes Berg
2007-03-22 13:26 ` Russell King [this message]
2007-03-22 13:31 ` Pavel Machek
2007-03-22 13:41 ` Vitaly Wool
2007-03-22 14:03 ` Pavel Machek
2007-03-22 14:27 ` Vitaly Wool
2007-03-22 14:33 ` Pavel Machek
2007-03-22 15:23 ` Johannes Berg
2007-03-22 15:26 ` Vitaly Wool
2007-03-22 14:24 ` Paul Mundt
2007-03-22 14:33 ` Pavel Machek
2007-03-22 14:35 ` Paul Mundt
2007-03-22 17:36 ` Andrew Morton
2007-03-22 17:51 ` Johannes Berg
2007-03-22 15:05 ` Johannes Berg
2007-03-22 15:23 ` Vitaly Wool
2007-03-22 15:28 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2007-03-22 18:00 akpm
2007-04-27 22:11 ` Johannes Berg
2007-04-27 22:55 ` Andrew Morton
2007-04-28 6:40 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070322132622.GD29627@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox