From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King Subject: Re: + rework-pm_ops-pm_disk_mode-kill-misuse.patch added to -mm tree Date: Thu, 22 Mar 2007 13:26:23 +0000 Message-ID: <20070322132622.GD29627@flint.arm.linux.org.uk> References: <200703212334.l2LNYDjj007030@shell0.pdx.osdl.net> <20070322094825.GA29627@flint.arm.linux.org.uk> <20070322015614.dafa1ed7.akpm@linux-foundation.org> <20070322100355.GA6834@elf.ucw.cz> <1174558128.3944.78.camel@johannes.berg> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1174558128.3944.78.camel@johannes.berg> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Johannes Berg Cc: Pavel Machek , Andrew Morton , linux-pm@lists.linux-foundation.org List-Id: linux-pm@vger.kernel.org On Thu, Mar 22, 2007 at 11:08:48AM +0100, Johannes Berg wrote: > No, once SOFTWARE_SUSPEND is configured there's *no way* to disable it > after the fact via pm_ops. Read valid_state() in kernel/power/main.c. So how does a platform with only flash (and an insufficient amount of flash at that) tell the suspend code that suspend-to-disk is not supported? > But that's a design decision, once the kernel config allows suspend to > disk runtime pm_ops have no say in it. It sounds like it's a very bad design decision. Maybe if you consider that the entire world is desktop PCs then it might make sense. That isn't the case though so it doesn't. Please fix your broken design. -- = Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: