Re: [PATCH] implement pm_ops.valid for everybody

Rafael J. Wysocki
2007-03-24T21:36:49Z

On Saturday, 24 March 2007 21:49, David Brownell wrote:
> On Friday 23 March 2007 1:39 pm, Rafael J. Wysocki wrote:
>
> > After we have frozen tasks, we need to
> > call something like device_suspend(some_argument) where the argument should
> > tell drivers what to do.
>
> That parameter can't suffice, since the exact details depend on
> system-dependent context. Example, on one system a given sleep
> state will allow a given device to issue wakeups ... on another,
> it won't.
>
> You seem to have overlooked the clk_must_disable() patches I
> recently re-sent. In conjunction with the driver model wakeup
> flags, that can solve the problem on every SOC platform I've
> had a reason to look at ... see how it works for AT91 USB.

Do I understand correctly that the idea is to introduce some functions
(eg. clk_must_disable()) that each platform can define differently and
that can be used by device drivers to obtain the additional information
needed to figure out what they are expected to do in .suspend()?

Rafael