Re: [PATCH] implement pm_ops.valid for everybody

David Brownell
2007-03-22T18:13:04Z

On Thursday 22 March 2007 10:18 am, Johannes Berg wrote:
> On Thu, 2007-03-22 at 10:10 -0700, David Brownell wrote:
>
> > especially the way suspend() methods
> > have no way to determine the semantics of the target state.
>
> I can't parse that.

Look at docs for most any SOC processor and you'll see that
not only does it have a variety of lowpower states, but that
each of them has various rules about what works there and
what doesn't.

So long as driver suspend() methods have no some way to see
how far they "must" shut down for a given target sleep state,
there is only limited utility to defining such states.

That's because the state would only really apply to the cpu
specific code ... drivers must assume the worst case, precluding
the primary reasons to use those less-deep system states.

I just reposted my clk_must_disable() patches; I think it's time
to merge them. They address that issue for one of the most
common type of rule for system sleep states ... at least, in
terms of interface. Platform support will still be an issue,
but at least the issue won't be "crippled by bad design".

- Dave