Re: [PATCH] remove software_suspend() and fix compile w/ SOFTWARE_SUSPEND disabled

[Pavel Machek <pavel@ucw.cz>]

Hi!

> This patch kills off software_suspend() and all it's users,
> pm_suspend(PM_SUSPEND_DISK) is much cleaner anyway. Also, this
> makes the kernel compile again w/o CONFIG_SOFTWARE_SUSPEND after
> Rafael's patches to kill the suspend pageflags broke it.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> Cc: Rafael J. Wysocki <rjw@sisk.pl>


>  	return error;
>  }
>  
> -/*
> - * This is main interface to the outside world. It needs to be
> - * called from process context.
> - */
> -int software_suspend(void)
> -{
> -	return enter_state(PM_SUSPEND_DISK);
> -}
> -
> -
...
> @@ -60,7 +60,7 @@ acpi_system_write_sleep(struct file *fil
>  	state = simple_strtoul(str, NULL, 0);
>  #ifdef CONFIG_SOFTWARE_SUSPEND
>  	if (state == 4) {
> -		error = software_suspend();
> +		error = pm_suspend(PM_SUSPEND_DISK);
>  		goto Done;
>  	}

Is enter_state and pm_suspend equivalent? Why the change?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html