Re: [PATCH v2] Add suspend/resume for HPET

Linus Torvalds
2007-03-31T17:09:15Z

On Sat, 31 Mar 2007, Maxim Levitsky wrote:
>
> So maybe I was right afrer all,
> Maybe it is better to add a suspend/resume hook to each clock source and call
> it from timekeeping_resume() ?

Umm.. WHy not make the device tree look like this:

-- "clocksource" -- +-- HPET
|
+-- TSC
|
+-- i8259
|
+-- lapic timer
|
.. whatever else

and use the "struct device" that we *have* for this? The whole "struct
device" is literally designed to do this, and to be embedded into whatever
bigger structures you have that describes higher-level behaviour. Ie you'd
put a "struct device" inside the "struct clocksource".

That thingalready *has* the suspend/resume hooks, and it will mean that
people will see the clocks in the device tree rather than have a new
notion.

Linus