Re: Power Mangement Interfaces

Matthew Garrett
2007-04-02T19:40:39Z

On Mon, Apr 02, 2007 at 11:24:21AM -0700, David Brownell wrote:

> I don't follow this at all. Most of the relevant devices have a PCI
> device driver, not an ACPI device driver. Surely you aren't proposing
> that PCI drivers should incorporate lots of ACPI-specific code (which
> won't be useful on non-ACPI platforms) before they start to work right?

PCI devices have a handle to their ACPI object in platform_data, so it's
easy enough to have generic code that interacts with both objects.

> For a PCI device driver, pci_enable_wake() is all the hook that it should
> ever need. If ACPI magic is needed, it should be called from inside that
> routine.

Yeah, I don't see that being a problem.

--
Matthew Garrett | mjg59@srcf.ucam.org