Re: [PATCH] OLPC rtc-cmos support

David Brownell
2007-07-08T20:47:34Z

> > > + (void)platform_device_register(&olpc_rtc_device);
> > > +
> > > + device_init_wakeup(&olpc_rtc_device.dev, 1);
> >
> > ... do the init_wakeup before registering the device, so
> > there can never be confusion about whether a probe() will
> > see that part of device config ...
>
> For some reason doing things in that order causes wake_on/wake_off
> to not be called...

I see ... because platform_device_register() will device_initialize()
which clobbers that state, before doing platform_device_add(). I
wonder what bugs are lurking thereby. :(

> Thanks again for the comments.

This last version looks clean and OK, so long as the driver registers
after that arch_initcall().

Really, no day field in the alarm for that particular southbridge?
Too bad. And a bit surprising ... I thought current versions of
ACPI required the up-to-one-month enhancement to mc146818.

- Dave