Re: [atl1-devel] BUG? WOL from S3

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Wednesday, 11 April 2007 00:38, 'Luca Tettamanti' wrote:
> Il Fri, Apr 06, 2007 at 09:41:31AM +0800, huang xiong ha scritto: 
> > > > I do the same test over Intel/Realtek PCIE gigabit Ethernet adapter.
> > > >
> > > > And found the .resume function is called before the system really go to
> > > > sleep.
> > > >
> > > > And because some shared hardware circuit. Attansic's nic can't enable both
> > > > normal tx/rx setting and WOL setting.
> > > >
> > > > So attansic's linux driver think the system wakeup when the .resume is
> > > > called, and it clear all WOL setting and back to normal tx/rx setting.
> > 
> > > Hum, what you describe seems to be suspend-to-disk:
> > > 
> > > ->suspend(PMSG_FREEZE)
> > > take snapshot
> > > ->resume() for writing the image
> > > write snapshot
> > > ->suspend(PMSG_SUSPEND)
> >
> >      You are right. It's suspend-to-disk.
> >      Could you explain calling sequence of .suspend and .resume when the
> > system goes to sleep for me ? such as S3/S4/...
> >      I confused what the driver should do when .resume is called.
> 
> It should restore the normal state of the device. The first suspend
> (PMSG_FREEZED) puts the device into a quiescent state (e.g. DMA transfers
> shall be stopped). The system is then resumed so that the image can be
> written to the disk. The second and final suspend call (PMSG_SUSPEND) is
> done before shutting down the system.

Er, no.  The system is just shut down, without suspending devices.

> > But It seems the system didn't called second .suspend.
> 
> Ouch. This is very strange. I'm adding a few of CC.

Well, that's how it works now.  We have considered suspending devices before
powering off for a while, but only theoretically.  If there's any additional
reason to do it, I think we can.

Greetings,
Rafael