From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: Linux 2.6.21-rc6 Date: Sun, 15 Apr 2007 10:19:35 -0400 Message-ID: <200704151019.37074.dtor@insightbb.com> References: <20070415080258.GA2716@melchior.yamamaya.is-a-geek.org> <200704151316.26136.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <200704151316.26136.rjw@sisk.pl> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: "Rafael J. Wysocki" Cc: Maxim Levitsky , Tobias Diedrich , linux-pm@lists.osdl.org, Linux Kernel Mailing List , Adrian Bunk List-Id: linux-pm@vger.kernel.org On Sunday 15 April 2007 07:16, Rafael J. Wysocki wrote: > On Sunday, 15 April 2007 10:02, Tobias Diedrich wrote: > = > > > With CONFIG_PM_DEBUG=3Dy and CONFIG_DISABLE_CONSOLE_SUSPEND=3Dy I see > > > that the second suspend hangs at "i8042 i8042: EARLY resume". > > > This is kinda interesting because I'm normally using a USB keyboard > > > and sure enough, if I hook up a normal keyboard and disable USB > > > legacy support in the BIOS, then suspend to disk works multiple > > > times. I'd still rather like to use my USB keyboard though. ;) > = > Well, I think that when you're using the USB keyboard and the USB legacy > support, the i8042 driver thinks it has a keyboard to handle and tries to > handle it during the suspend, which fails. I don't know why it fails dur= ing > the second suspend, though. > = > Dmitry, could you please have a look? > = This is wierd as i8042 does not use suspend_late/resume_early hooks and so it is impossible for it to hang there. None of input drivers use these hooks. Could it be that some other driver _after_ i8042 hangs? > > And I can now confirm that unpatched 2.6.21-rc6 works fine as long > > as USB legacy support is disabled (however without legacy support I > > can't use the USB keyboard to control grub). > = > I think using the 'shutdown' mode of suspend would be better. There's a = little > point in using 'platform' on desktop systems anyway. > = > Frankly, I don't know what to do about it. If we move platform_finish() = after > device_resume(), some systems may be broken and I think there are more su= ch > systems than there are systems that set USB legacy support in the BIOS and > have no PS/2 keyboards attached. I would say that every box that does not use PS/2 keyboard does this. IOW every box with USB keyboard has legacy emulation turned on so quite few of them... -- = Dmitry