From: David Brownell <david-b@pacbell.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-pm@lists.linux-foundation.org,
linux-pm <linux-pm@lists.osdl.org>,
Johannes Berg <johannes@sipsolutions.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] s2ram: add arch irq disable/enable hooks
Date: Sat, 21 Apr 2007 20:05:55 -0700 [thread overview]
Message-ID: <200704212005.55743.david-b@pacbell.net> (raw)
In-Reply-To: <20070421214405.GA2758@elf.ucw.cz>
On Saturday 21 April 2007, Pavel Machek wrote:
> Hi!
>
> > > int suspend_enter(suspend_state_t state)
> > > {
> > > int error = 0;
> > > - unsigned long flags;
> > >
> > > - local_irq_save(flags);
> > > + arch_s2ram_disable_irqs();
> >
> > Sorry for not highlighting this before, but these are badly misnamed.
> > They apply for every system suspend state except PM_SUSPEND_DISK ...
> > NOT just suspend-to-ram, as specified by the function name.
>
> Every suspend state means "standby" and "s2ram" in this context. I
> think this name is better than alternatives.
Every suspend state is **NOT** s2ram though.
This is a very straightforward point. A function that's
called on non-S2RAM paths shouldn't be named as if it's
only for S2RAM.
Ergo, those two functions are misnamed. End of story.
- Dave
next prev parent reply other threads:[~2007-04-22 3:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-19 11:00 [PATCH] s2ram: add arch irq disable/enable hooks Johannes Berg
2007-04-19 21:55 ` Andrew Morton
2007-04-20 15:34 ` Johannes Berg
2007-04-20 6:57 ` Greg KH
2007-04-20 15:31 ` Johannes Berg
2007-04-20 17:39 ` Greg KH
2007-04-20 19:37 ` Johannes Berg
2007-04-20 19:44 ` Andrew Morton
2007-04-20 19:51 ` Johannes Berg
2007-04-20 20:36 ` Rafael J. Wysocki
2007-04-20 20:51 ` Johannes Berg
2007-04-20 21:08 ` Rafael J. Wysocki
2007-04-21 13:57 ` Johannes Berg
2007-04-21 14:07 ` Pavel Machek
2007-04-21 15:41 ` David Brownell
2007-04-21 16:16 ` Johannes Berg
2007-04-21 16:55 ` David Brownell
2007-04-21 17:01 ` Johannes Berg
2007-04-21 17:06 ` David Brownell
2007-04-21 17:49 ` Johannes Berg
2007-04-21 21:47 ` Pavel Machek
2007-04-21 22:04 ` Johannes Berg
2007-04-21 21:45 ` Pavel Machek
2007-04-22 3:10 ` David Brownell
2007-04-22 13:09 ` Pavel Machek
2007-04-26 11:02 ` David Woodhouse
2007-04-21 21:44 ` Pavel Machek
2007-04-22 3:05 ` David Brownell [this message]
2007-04-22 13:13 ` Pavel Machek
2007-04-24 13:51 ` Johannes Berg
2007-04-24 18:16 ` Pavel Machek
2007-04-25 3:45 ` David Brownell
-- strict thread matches above, loose matches on Subject: below --
2007-04-05 21:54 [PATCH] pm_ops: add irq enable/disable hooks Johannes Berg
2007-04-17 17:18 ` [PATCH] s2ram: add arch irq disable/enable hooks Johannes Berg
2007-04-18 11:27 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704212005.55743.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-pm@lists.osdl.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox