From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [RFC/PATCH 2/2] kernel: don't update load average during snapshot/shutdown Date: Sat, 28 Apr 2007 00:12:34 +0200 Message-ID: <20070427221234.GE2994@elf.ucw.cz> References: <20070427145212.GO22250@elf.ucw.cz> <1177709523.4737.157.camel@nigel.suspend2.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1177709523.4737.157.camel@nigel.suspend2.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Nigel Cunningham Cc: Pekka J Enberg , linux-pm@lists.osdl.org List-Id: linux-pm@vger.kernel.org Hi! > > NAK. This slows down regular operation, at it is 30 lines for what > > should have been one (or five). > > Count them. It is one line (an if statement) plus seven lines of > comment. You count them. Hint... you'll need to read original patch. > > Just place avenrun[0] = avenrun[1] = avenrun[2] = 0 at strategic place > > if you feel strongly about this. Additional points for using Rafael's > > "suspend done" notifier so that you don't have to modify suspend core. > > =0 might not be right. If you did have a high load average prior to > suspending, not delivering email would be the right thing to do. Ok, so =0 is not right, but it is better than adding 30lines of junk to the kernel. NAK on this patch. Original behaviour is acceptable. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html