From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [RFT][PATCH] swsusp: Change code ordering related to ACPI Date: Sat, 5 May 2007 11:50:21 +0200 Message-ID: <200705051150.22108.rjw@sisk.pl> References: <200705041143.02451.rjw@sisk.pl> <2c0942db0705041611u2d82fbb7m4719c1bcf8bcdbf7@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2c0942db0705041611u2d82fbb7m4719c1bcf8bcdbf7@mail.gmail.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Ray Lee Cc: LKML , Tobias Diedrich , Pavel Machek , Andrew Morton , Marcus Better , pm list List-Id: linux-pm@vger.kernel.org On Saturday, 5 May 2007 01:11, Ray Lee wrote: > On 5/4/07, Rafael J. Wysocki wrote: > > The change of the hibernation/suspend code ordering made before 2.6.21 has > > caused some systems to have problems related to ACPI. In particular, the > > 'platform' hibernation mode doesn't work any more on some systems. > > It seems that somewhere between 2.6.21-rc4 and 2.6.21 final my laptop > stopped being able to come out of suspend to RAM. Before I start > bisecting (again, sigh), is this ringing any bells for anyone? In > particular your, patch (snipped) that deals with hibernation, would it > also affect suspend to RAM? Not this particular one, but you may try to move pm_finish() after resume_console() in kernel/power/main.c:suspend_prepare() and see if that helps. If it doesn't help, then try to compile the kernel with NO_HZ and HIGH_RES_TIMERS unset. If that doesn't help, you may try with HPET_TIMER unset additionally. Greetings, Rafael