From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers Date: Mon, 28 May 2007 15:12:43 +0200 Message-ID: <20070528131243.GP18807@elf.ucw.cz> References: <200705272229.21263.rjw@sisk.pl> <200705272230.04478.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <200705272230.04478.rjw@sisk.pl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: "Rafael J. Wysocki" Cc: Matthew Garrett , LKML , pm list List-Id: linux-pm@vger.kernel.org Hi! > Make it possible to register hibernation and suspend notifiers, so that > subsystems can perform hibernation-related or suspend-related operations that > should not be carried out by device drivers' .suspend() and > .resume() routines. I believe it adds _way_ too many notifiers. > +PM_PRE_FREEZE The system is going to hibernate or suspend, tasks will > + be frozen immediately 80 columns. Anyway yes, this one is needed. > +PM_POST_THAW Tasks have just been thawed after a resume or restore > + from a hibernation image Symetrical with the previous one, useful for freeing firmware images, ok. > +PM_HIBERNATION_PREPARE The system is preparing for hibernation. Tasks have > + been frozen, memory is going to be freed and devices > + are going to be suspended. What is this one good for? > +PM_SNAPSHOT_FAILED The creation of hibernation image has failed. Tasks > + will be thawed immediately. Does this one need to be different from POST_THAW? I do not see the need for the other chains. Notice that we do not _want_ to have too many of them, because changing anything in the hibernation will become impossible with 10 chains having intimate details of suspend sequence. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html