Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware before hibernation/suspend

Alan Stern
2007-05-28T15:55:22Z

On Sun, 27 May 2007, Rafael J. Wysocki wrote:

> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Use a hibernation and suspend notifier to disable the firmware requesting
> mechanism before a hibernation/suspend and enable it after the operation.

You're using the PM_PRE_FREEZE and PM_POST_THAW notifiers for both this
and the userspace helper change. Is it your intention that drivers
should continue to request these services but encounter an error if the
request occurs at the wrong time? Or do you expect drivers to use the
notifier chains to know when they shouldn't make any requests?

In the second case you may have a problem, because there's no
specification about the order in which the notifiers are sent. The
service may get disabled before the driver learns it isn't available,
or the driver may think the service is once again available before it
gets enabled.

Alan Stern