Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware before hibernation/suspend

Pavel Machek
2007-05-28T13:01:25Z

Hi!

> >From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> >Use a hibernation and suspend notifier to disable the firmware
> >requesting
> >mechanism before a hibernation/suspend and enable it after the
> >operation.
> >
> >Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > drivers/base/firmware_class.c | 36 ++++++++++++++++++++++++++++++
> >++++++
> > 1 file changed, 36 insertions(+)
>
> I don't like this approach, as I feel that the firmware loading
> interface should be able to detect if a firmware load request is not
> being handled, due to absence of userspace / hotplug handler presence.

I don't think that's possible. If hotplug handler needs /dev/foo, but
/dev/foo is not available, it will just block waiting there.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html