Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware before hibernation/suspend

Kay Sievers
2007-05-28T09:06:11Z

On Mon, 2007-05-28 at 09:48 +0100, Michael-Luke Jones wrote:
> On 28 May 2007, at 08:43, Rafael J. Wysocki wrote:
>
> >> Seems, that's just the broken synchronous firmware loading interface
> >> with the useless timeout handling. The nowait version of the same
> >> loader
> >> doesn't time out, and should not have that problem. The sync version
> >> should be removed from the kernel, it just causes all sorts of
> >> problems
> >> since it exists.
> >>
> >> Userspace should handle the async request just fine when it comes
> >> back
> >> running, regardless of the time it was submitted.
> >
> > Okay, so the solution is to convert the drivers to use
> > request_firmware_nowait() instead of request_firmware() in
> > their .resume()
> > routines.
>
> [added Rob Landley to CC]
>
> I think asynchronous loading should be made the default behaviour.
> However, we need to think and document how to do firmware loading.
>
> Firmware loading can be done at two different times:
> Device Driver Load
> First use of Device Driver
>
> For a network device, this correlates to when the driver is first
> loaded into memory or at 'ifconfig up' respectively.
>
> At device driver load, firmware loading must be asynchronous. This is
> because device driver init can occur before userspace runs and
> registers a hotplug/uevent event handler. If device use is attempted
> before firmware loads, a -ENOFIRMWARE call would be great so that
> userspace and thus the user can be clearly informed what the problem is.

Why would a driver create an interface before it has the needed
firmware loaded?

> However, at 'first use' firmware loading, the synchronous interface
> should remain. 'ifconfig up' either works or it doesn't, and as I see
> it, has to just hang around until firmware turns up.

What kind of network driver does create an interface for a
non-functioning device? That sounds like a bug on its own.

If a driver binds to a device, it should just have the firmware already
loaded, and not wait until its used. What's the reason for such a
behavior, to let a driver pretend it can handle a device, but it doesn't
even know if all the needed pieces are available on the system?

> One more thing, it seems that the asynchronous firmware loading
> thread just spawns a _request_firmware() call which then times out at
> 60 seconds. I think, if the first request fails it spawns another. 60
> seconds is *far* too long for this type of thing, and this was set at
> 10 seconds before the last two kernel releases (which is even a bit
> slow itself). Unfortunately, this appears to a case of quite senior
> kernel developers pushing a bodge upstream rather than fixing the
> underlying issue :( [1] [2]

The underlying issue are the driver authors, that's not so easy to
fix. :)

Well, 10 seconds are just to short for userspace to react on some
setups, from tiny boxes which are busy, to 512 CPU boxes enumerating
thousands of devices, all had problems here. Any timeout for a
firmware-request is just a broken concept, the request should wait
forever, to be fulfilled or canceled from userspace when it's ready.

Kay