From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [-mm patch] kernel/power/disk.c: make code static
Date: Wed, 6 Jun 2007 00:10:44 +0200 [thread overview]
Message-ID: <200706060010.45107.rjw@sisk.pl> (raw)
In-Reply-To: <20070605215049.GI5500@stusta.de>
On Tuesday, 5 June 2007 23:50, Adrian Bunk wrote:
> On Wed, May 30, 2007 at 11:58:23PM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.22-rc2-mm1:
> >...
> > +swsusp-remove-code-duplication-between-diskc-and-userc.patch
> >...
> > freezer/swsusp updates
> >...
>
> This patch makes needlessly global code static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
ACK
Rafael
> ---
>
> kernel/power/disk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2.6.22-rc3-mm1/kernel/power/disk.c.old 2007-06-05 22:12:07.000000000 +0200
> +++ linux-2.6.22-rc3-mm1/kernel/power/disk.c 2007-06-05 22:13:37.000000000 +0200
> @@ -45,7 +45,7 @@
>
> static int hibernation_mode = HIBERNATION_SHUTDOWN;
>
> -struct hibernation_ops *hibernation_ops;
> +static struct hibernation_ops *hibernation_ops;
>
> /**
> * hibernation_set_ops - set the global hibernate operations
> @@ -231,7 +231,7 @@
> * to power off or reboot.
> */
>
> -void power_down(void)
> +static void power_down(void)
> {
> switch (hibernation_mode) {
> case HIBERNATION_TEST:
>
>
>
--
"Premature optimization is the root of all evil." - Donald Knuth
prev parent reply other threads:[~2007-06-05 22:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070530235823.793f00d9.akpm@linux-foundation.org>
2007-05-31 15:29 ` 2.6.22-rc3-mm1 Michal Piotrowski
[not found] ` <465EE9F2.8080905@googlemail.com>
2007-05-31 19:58 ` 2.6.22-rc3-mm1 Rafael J. Wysocki
[not found] ` <200705312158.26560.rjw@sisk.pl>
2007-05-31 21:25 ` 2.6.22-rc3-mm1 Michal Piotrowski
2007-05-31 21:34 ` 2.6.22-rc3-mm1 Rafael J. Wysocki
2007-05-31 21:30 ` [PATCH -mm] Freezer: migration_thread should not be freezable (was: Re: Re: 2.6.22-rc3-mm1) Rafael J. Wysocki
[not found] ` <200705312330.09157.rjw@sisk.pl>
2007-05-31 21:45 ` Michal Piotrowski
2007-06-05 21:50 ` [-mm patch] kernel/power/disk.c: make code static Adrian Bunk
2007-06-05 22:10 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706060010.45107.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox