From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [-mm patch] kernel/power/disk.c: make code static Date: Wed, 6 Jun 2007 00:10:44 +0200 Message-ID: <200706060010.45107.rjw@sisk.pl> References: <20070530235823.793f00d9.akpm@linux-foundation.org> <20070605215049.GI5500@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070605215049.GI5500@stusta.de> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Adrian Bunk Cc: Andrew Morton , linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org List-Id: linux-pm@vger.kernel.org On Tuesday, 5 June 2007 23:50, Adrian Bunk wrote: > On Wed, May 30, 2007 at 11:58:23PM -0700, Andrew Morton wrote: > >... > > Changes since 2.6.22-rc2-mm1: > >... > > +swsusp-remove-code-duplication-between-diskc-and-userc.patch > >... > > freezer/swsusp updates > >... > > This patch makes needlessly global code static. > > Signed-off-by: Adrian Bunk ACK Rafael > --- > > kernel/power/disk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- linux-2.6.22-rc3-mm1/kernel/power/disk.c.old 2007-06-05 22:12:07.000000000 +0200 > +++ linux-2.6.22-rc3-mm1/kernel/power/disk.c 2007-06-05 22:13:37.000000000 +0200 > @@ -45,7 +45,7 @@ > > static int hibernation_mode = HIBERNATION_SHUTDOWN; > > -struct hibernation_ops *hibernation_ops; > +static struct hibernation_ops *hibernation_ops; > > /** > * hibernation_set_ops - set the global hibernate operations > @@ -231,7 +231,7 @@ > * to power off or reboot. > */ > > -void power_down(void) > +static void power_down(void) > { > switch (hibernation_mode) { > case HIBERNATION_TEST: > > > -- "Premature optimization is the root of all evil." - Donald Knuth