From: Pavel Machek <pavel@ucw.cz>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-pm@lists.linux-foundation.org,
Elimar Riesebieter <riesebie@lxtec.de>
Subject: Re: 2.6.22-rc2 built on ppc (1)
Date: Sat, 9 Jun 2007 16:14:21 +0200 [thread overview]
Message-ID: <20070609141421.GC3397@elf.ucw.cz> (raw)
In-Reply-To: <1179661437.3590.11.camel@johannes.berg>
Hi!
> > > kernel/power/swsusp.c: In function 'swsusp_show_speed':
> > > kernel/power/swsusp.c:193: warning: comparison of distinct pointer types lacks a cast
> >
> > Well, this warning doesn't make sense. In 2.6.22-rc2 line 193 of swsusp.c is
> >
> > do_div(elapsed_centisecs64, NSEC_PER_SEC / 100);
> >
> > where elapsed_centisecs64 is s64.
>
> yeah, and the do_div64 macro is then comparing (s64*) == (u64*) in a
> null-statement and tells you that the types are different. I tracked
> this a long time ago and figured it wasn't worth thinking about.
Elimar, can you modify the code to
do_div(elapsed_centisecs64, (s64) NSEC_PER_SEC / 100);
...to see if the warning goes away?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-06-09 14:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-20 11:06 2.6.22-rc2 built on ppc (1) Elimar Riesebieter
2007-05-20 11:36 ` Rafael J. Wysocki
2007-05-20 11:43 ` Johannes Berg
2007-06-09 14:14 ` Pavel Machek [this message]
2007-06-09 17:06 ` Elimar Riesebieter
2007-06-11 8:26 ` Johannes Berg
2007-06-09 13:55 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070609141421.GC3397@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-pm@lists.linux-foundation.org \
--cc=riesebie@lxtec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox