public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Elimar Riesebieter <riesebie@lxtec.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	linux-pm@lists.linux-foundation.org
Subject: Re: 2.6.22-rc2 built on ppc (1)
Date: Sat, 9 Jun 2007 19:06:47 +0200	[thread overview]
Message-ID: <20070609170647.GA5358@frodo.home.lxtec.de> (raw)
In-Reply-To: <20070609141421.GC3397@elf.ucw.cz>


[-- Attachment #1.1: Type: text/plain, Size: 921 bytes --]

On Sat, 09 Jun 2007 the mental interface of
Pavel Machek told:

> Hi!
> 
> > > > kernel/power/swsusp.c: In function 'swsusp_show_speed':
> > > > kernel/power/swsusp.c:193: warning: comparison of distinct pointer types lacks a cast
> > > 
> > > Well, this warning doesn't make sense.  In 2.6.22-rc2 line 193 of swsusp.c is
> > > 
> > > do_div(elapsed_centisecs64, NSEC_PER_SEC / 100);
> > > 
> > > where elapsed_centisecs64 is s64.
> > 
> > yeah, and the do_div64 macro is then comparing (s64*) == (u64*) in a
> > null-statement and tells you that the types are different. I tracked
> > this a long time ago and figured it wasn't worth thinking about.
> 
> Elimar, can you modify the code to 
> 
> do_div(elapsed_centisecs64, (s64) NSEC_PER_SEC / 100);
> 
> ...to see if the warning goes away?

Same warning :(

Elimar

-- 
  It's a good thing we don't get all 
  the government we pay for.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2007-06-09 17:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-20 11:06 2.6.22-rc2 built on ppc (1) Elimar Riesebieter
2007-05-20 11:36 ` Rafael J. Wysocki
2007-05-20 11:43   ` Johannes Berg
2007-06-09 14:14     ` Pavel Machek
2007-06-09 17:06       ` Elimar Riesebieter [this message]
2007-06-11  8:26       ` Johannes Berg
2007-06-09 13:55 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070609170647.GA5358@frodo.home.lxtec.de \
    --to=riesebie@lxtec.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox