From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [RFC][PATCH] PM: Remove code duplication between main.c and user.c
Date: Thu, 21 Jun 2007 15:28:15 +0200 [thread overview]
Message-ID: <20070621132815.GF18392@elf.ucw.cz> (raw)
In-Reply-To: <200706182231.04203.rjw@sisk.pl>
Hi!
> The SNAPSHOT_S2RAM ioctl code is outdated and it should not duplicate the
> suspend code in kernel/power/main.c. Fix that.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Mostly works ok, but
> +/**
> + * suspend_suspend - suspend devices and enter the desired system sleep
> + * state.
> + * @state: state to enter
> + */
> +int suspend_suspend(suspend_state_t state)
This is really horrible name. Maybe this should be suspend_enter, and
suspend_enter should become __suspend_enter, or something?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-06-21 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-18 20:31 [RFC][PATCH] PM: Remove code duplication between main.c and user.c Rafael J. Wysocki
2007-06-21 13:28 ` Pavel Machek [this message]
2007-06-21 15:07 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070621132815.GF18392@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox