From: Pavel Machek <pavel@ucw.cz>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Len Brown <len.brown@intel.com>,
linux acpi <linux-acpi@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [RFC/RFT][PATCH -mm 1/4] PM: Introduce set_target method in pm_ops
Date: Tue, 26 Jun 2007 10:55:13 +0200 [thread overview]
Message-ID: <20070626085513.GD4594@elf.ucw.cz> (raw)
In-Reply-To: <1182806886.6644.4.camel@johannes.berg>
On Mon 2007-06-25 23:28:06, Johannes Berg wrote:
> On Sun, 2007-06-24 at 22:40 +0200, Rafael J. Wysocki wrote:
>
> > + * @set_target: Tell the platform which system sleep state is going to be
> > + * entered. The information passed to @set_target should be disregarded
> > + * by the platform as soon as @finish() is executed and if @prepare()
> > + * fails.
> > + * This callback is optional. However, if it is implemented, the
> > + * argument passed to @prepare(), @enter and @finish() must be ignored.
>
> I don't understand the point in mandating that then the argument to
> enter() is to be ignored, why bother? It doesn't look as though we can
> possibly do anything with the semantics here that would mean the state
> set by set_target is different to the state passed to enter(), can we?
That's what 4/4 does, AFAICT.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-06-26 8:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200706242239.05678.rjw@sisk.pl>
2007-06-24 20:40 ` [RFC/RFT][PATCH -mm 1/4] PM: Introduce set_target method in pm_ops Rafael J. Wysocki
2007-06-24 20:41 ` [RFC/RFT][PATCH -mm 2/4] PM: Move definition of struct pm_ops to suspend.h Rafael J. Wysocki
2007-06-24 20:42 ` [RFC/RFT][PATCH -mm 3/4] PM: Rename struct pm_ops and related things Rafael J. Wysocki
2007-06-24 20:44 ` [RFC/RFT][PATCH -mm 4/4] PM: Rework struct platform_suspend_operations Rafael J. Wysocki
[not found] ` <200706242240.40476.rjw@sisk.pl>
2007-06-25 2:11 ` [RFC/RFT][PATCH -mm 1/4] PM: Introduce set_target method in pm_ops David Brownell
2007-06-25 21:28 ` Johannes Berg
[not found] ` <200706241911.18201.david-b@pacbell.net>
2007-06-25 22:06 ` Rafael J. Wysocki
[not found] ` <1182806886.6644.4.camel@johannes.berg>
2007-06-26 8:55 ` Pavel Machek [this message]
2007-06-26 9:41 ` Rafael J. Wysocki
[not found] ` <200706261141.35071.rjw@sisk.pl>
2007-06-26 17:19 ` David Brownell
[not found] ` <200706261019.59712.david-b@pacbell.net>
2007-06-26 20:14 ` Rafael J. Wysocki
[not found] ` <200706242242.47573.rjw@sisk.pl>
2007-06-25 4:12 ` [RFC/RFT][PATCH -mm 3/4] PM: Rename struct pm_ops and related things David Brownell
2007-06-25 19:34 ` Pavel Machek
[not found] ` <200706242241.39283.rjw@sisk.pl>
2007-06-25 19:33 ` [RFC/RFT][PATCH -mm 2/4] PM: Move definition of struct pm_ops to suspend.h Pavel Machek
[not found] ` <200706242244.51335.rjw@sisk.pl>
2007-06-25 21:30 ` [RFC/RFT][PATCH -mm 4/4] PM: Rework struct platform_suspend_operations Johannes Berg
2007-06-25 22:39 ` [RFC/RFT][PATCH -mm 0/8] PM: Rework struct pm_ops and related things (take 2) Rafael J. Wysocki
[not found] ` <200706260039.17530.rjw@sisk.pl>
2007-06-25 22:41 ` [RFC/RFT][PATCH -mm 1/8][bugfix] PM: Introduce set_target method in pm_ops Rafael J. Wysocki
2007-06-25 22:43 ` [RFC/RFT][PATCH -mm 2/8] ACPI: Implement the set_target() callback from pm_ops Rafael J. Wysocki
2007-06-25 22:45 ` [RFC/RFT][PATCH -mm 3/8] ACPI: Add acpi_pm_device_sleep_state helper routine Rafael J. Wysocki
2007-06-25 22:47 ` [RFC/RFT][PATCH -mm 4/8] PM: Move definition of struct pm_ops to suspend.h Rafael J. Wysocki
2007-06-25 22:48 ` [RFC/RFT][PATCH -mm 5/8] PM: Rename struct pm_ops and related things Rafael J. Wysocki
2007-06-25 22:49 ` [RFC/RFT][PATCH -mm 6/8] PM: Rework struct platform_suspend_operations Rafael J. Wysocki
2007-06-25 22:51 ` [RFC/RFT][PATCH -mm 7/8] PM: Rework struct hibernation_ops Rafael J. Wysocki
2007-06-25 22:52 ` [RFC/RFT][PATCH -mm 8/8] PM: Rename hibernation_ops to platform_hibernation_operations Rafael J. Wysocki
[not found] ` <200706260049.40457.rjw@sisk.pl>
2007-06-26 8:52 ` [RFC/RFT][PATCH -mm 6/8] PM: Rework struct platform_suspend_operations Pavel Machek
[not found] ` <200706260052.28206.rjw@sisk.pl>
2007-06-26 8:54 ` [RFC/RFT][PATCH -mm 8/8] PM: Rename hibernation_ops to platform_hibernation_operations Pavel Machek
2007-06-27 15:19 ` Rafael J. Wysocki
[not found] ` <200706260045.51039.rjw@sisk.pl>
2007-06-26 10:00 ` [RFC/RFT][PATCH -mm 3/8] ACPI: Add acpi_pm_device_sleep_state helper routine (updated) Rafael J. Wysocki
[not found] ` <200706261200.29421.rjw@sisk.pl>
2007-06-26 10:34 ` [RFC/RFT][PATCH -mm 3/8] ACPI: Add acpi_pm_device_sleep_state helper routine (updated 2x) Rafael J. Wysocki
[not found] ` <200706260041.20561.rjw@sisk.pl>
2007-06-27 20:27 ` [RFC/RFT][PATCH -mm 1/8][bugfix] PM: Introduce set_target method in pm_ops Rafael J. Wysocki
2007-06-27 20:41 ` David Brownell
[not found] ` <200706271341.53599.david-b@pacbell.net>
2007-06-27 20:55 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070626085513.GD4594@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=johannes@sipsolutions.net \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox