From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Len Brown <len.brown@intel.com>,
linux acpi <linux-acpi@vger.kernel.org>,
Russell King <rmk@arm.linux.org.uk>,
pm list <linux-pm@lists.linux-foundation.org>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [RFC][PATCH -mm 4/9] PM: Rename struct pm_ops and related things
Date: Sun, 1 Jul 2007 01:04:52 +0200 [thread overview]
Message-ID: <20070630230452.GC1855@elf.ucw.cz> (raw)
In-Reply-To: <200706302303.59457.rjw@sisk.pl>
On Sat 2007-06-30 23:03:57, Rafael J. Wysocki wrote:
> [Previous version of this was acked by Pavel, but I've updated it since then.]
> ---
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> The name of 'struct pm_ops' suggests that it is related to the power management
> in general, but in fact it is only related to suspend. Moreover, its name
> should indicate what this structure is used for, so it seems reasonable to
> change it to 'struct platform_suspend_ops'. In that case, the name of
> the global variable of this type used by the PM core and the names of related
> functions should be changed accordingly.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
ACK.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-06-30 23:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200706302257.17556.rjw@sisk.pl>
2007-06-30 20:58 ` [RFC][PATCH -mm 1/9] ACPI: Implement the set_target() callback from pm_ops Rafael J. Wysocki
2007-06-30 20:59 ` [RFC][PATCH -mm 2/9] ACPI: Add acpi_pm_device_sleep_state helper routine Rafael J. Wysocki
2007-06-30 21:01 ` [RFC][PATCH -mm 3/9] PM: Move definition of struct pm_ops to suspend.h Rafael J. Wysocki
2007-06-30 21:03 ` [RFC][PATCH -mm 4/9] PM: Rename struct pm_ops and related things Rafael J. Wysocki
2007-06-30 21:07 ` [RFC][PATCH -mm 5/9] PM: Rework struct platform_suspend_ops Rafael J. Wysocki
2007-06-30 21:08 ` [RFC][PATCH -mm 6/9] PM: Fix compilation of suspend code if CONFIG_PM is unset Rafael J. Wysocki
2007-06-30 21:09 ` [RFC][PATCH -mm 7/9] PM: Make suspend_ops static Rafael J. Wysocki
2007-06-30 21:10 ` [RFC][PATCH -mm 8/9] PM: Rework struct hibernation_ops Rafael J. Wysocki
2007-06-30 21:11 ` [RFC][PATCH -mm 9/9] PM: Rename hibernation_ops to platform_hibernation_ops Rafael J. Wysocki
[not found] ` <200706302301.57528.rjw@sisk.pl>
2007-06-30 23:04 ` [RFC][PATCH -mm 3/9] PM: Move definition of struct pm_ops to suspend.h Pavel Machek
[not found] ` <200706302303.59457.rjw@sisk.pl>
2007-06-30 23:04 ` Pavel Machek [this message]
[not found] ` <200706302309.58612.rjw@sisk.pl>
2007-06-30 23:06 ` [RFC][PATCH -mm 7/9] PM: Make suspend_ops static Pavel Machek
[not found] ` <200706302311.59630.rjw@sisk.pl>
2007-06-30 23:06 ` [RFC][PATCH -mm 9/9] PM: Rename hibernation_ops to platform_hibernation_ops Pavel Machek
2007-06-30 23:22 ` [RFC][PATCH -mm 0/9] PM: Update global suspend and hibernation operations framework Russell King
[not found] ` <20070630232222.GA8100@flint.arm.linux.org.uk>
2007-07-01 10:01 ` Rafael J. Wysocki
2007-07-02 4:28 ` David Brownell
[not found] ` <200706302259.48700.rjw@sisk.pl>
2007-07-02 5:49 ` [RFC][PATCH -mm 2/9] ACPI: Add acpi_pm_device_sleep_state helper routine David Brownell
[not found] ` <200707012249.14143.david-b@pacbell.net>
2007-07-02 8:17 ` Rafael J. Wysocki
[not found] ` <200707021017.01295.rjw@sisk.pl>
2007-07-02 17:24 ` David Brownell
[not found] ` <200707021024.58693.david-b@pacbell.net>
2007-07-02 20:15 ` Rafael J. Wysocki
[not found] ` <200707022215.09354.rjw@sisk.pl>
2007-07-03 13:58 ` Rafael J. Wysocki
[not found] ` <200707012128.41742.david-b@pacbell.net>
2007-07-02 14:28 ` [RFC][PATCH -mm 0/9] PM: Update global suspend and hibernation operations framework Rafael J. Wysocki
[not found] ` <200707021628.27139.rjw@sisk.pl>
2007-07-02 14:36 ` Russell King
[not found] ` <20070702143632.GC32096@flint.arm.linux.org.uk>
2007-07-02 20:17 ` Rafael J. Wysocki
2007-07-11 10:53 ` Pavel Machek
[not found] ` <20070711105334.GH7091@elf.ucw.cz>
2007-07-11 11:16 ` Rafael J. Wysocki
[not found] ` <200707111316.08388.rjw@sisk.pl>
2007-07-11 20:04 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070630230452.GC1855@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=johannes@sipsolutions.net \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox