From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: [PATCH] Remove process freezer from suspend to RAM pathway Date: Tue, 3 Jul 2007 20:26:34 +0200 Message-ID: <200707032026.34649.oliver@neukum.org> References: <20070703042916.GA17240@srcf.ucam.org> <200707031508.45595.rjw@sisk.pl> <200707031709.29968.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200707031709.29968.rjw@sisk.pl> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: "Rafael J. Wysocki" Cc: Matthew Garrett , linux-kernel@vger.kernel.org, Pavel Machek , linux-pm@lists.linux-foundation.org List-Id: linux-pm@vger.kernel.org Am Dienstag, 3. Juli 2007 schrieb Rafael J. Wysocki: > > > The main reason for deadlocks is because we do a sys_sync() after the > > > freeze, which we shouldn't do. > > > > So why don't we remove the sys_sync() from freeze_processes() instead? > > The patch follows (untested). And a further question. The freezer is not atomic. What do you do if a task not yet frozen calls sys_sync(), but fuse is already frozen? Regards Oliver