Re: Re: [PATCH] Remove process freezer from suspend to RAM pathway

Rafael J. Wysocki
2007-07-05T14:14:17Z

On Thursday, 5 July 2007 15:50, Miklos Szeredi wrote:
> > > > Don't you think, however, that it can be modified a little to play well,
> > > > for example, with the freezer?
> > >
> > > I could stick a couple of try_to_freeze()s into fuse, and that would
> > > make suspend failure less likely. But making problems less easy to
> > > reproduce is not a good thing.
> >
> > So, how about eliminating them?
>
> That can't be done just within fuse, a process might be sleeping on a
> VFS mutex. Do we want to hack VFS as well?

No.

> I guess I know your answer. But it ain't gonna work. Suspend code
> really doesn't belong in VFS, and I'm pretty sure the maintainers of
> that little piece of code would agree with me on this.

Surprise, surprise. Not that I'm scared of the VFS maintainers, though. ;-)

Greetings,
Rafael

--
"Premature optimization is the root of all evil." - Donald Knuth