Re: [PATCH] Remove process freezer from suspend to RAM pathway

Pavel Machek
2007-07-03T19:27:29Z

Hi!

> > > The main reason for deadlocks is because we do a sys_sync() after the
> > > freeze, which we shouldn't do.
> >
> > So why don't we remove the sys_sync() from freeze_processes() instead?
>
> The patch follows (untested).
>
> Greetings,
> Rafael
>
>
> ---
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> We shouldn't sync filesystems from within the freezer, because it's not needed
> for suspend to RAM and leads to problems with FUSE.

Actually... It is not _needed_ for suspend to disk, either. Snapshot is
atomic, so it should be okay to suspend with filesystems dirty.

_But_, if anything goes wrong, we'd prefer to have at least
filesystems synced. Battery running out during s2ram is not quite
uncommon, so we perhaps should do sync somewhere there. (But we can do
it before freezer just fine).
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html