From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [RFC][PATCH -mm] Freezer: Handle uninterruptible tasks Date: Sat, 7 Jul 2007 13:31:18 +0200 Message-ID: <20070707113118.GA2789@elf.ucw.cz> References: <200707061012.48998.rjw@sisk.pl> <20070707075018.GB2638@elf.ucw.cz> <200707071913.43482.nigel@nigel.suspend2.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <200707071913.43482.nigel@nigel.suspend2.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: nigel@suspend2.net Cc: Matthew Garrett , Miklos Szeredi , LKML , pm list , Ingo Molnar List-Id: linux-pm@vger.kernel.org Hi! > > I don't think we can do that. I suspect rename looks like: > > > > write directory entry in source > > A) (uninterruptible wait for write) > > write directory entry in destination > > (uninterruptible wait for write) > > write something else > > > > If we freeze some task in place "A)", we'll write to the disk when the > > directory write is finished :-(. > > Renaming is a single syscall, so won't the process get frozen when the syscall > finishes? It would be frozen when syscall finishes. But if we freeze it at A) point, we have a problem. > Perhaps you've just found more logic for keeping the sys_sync there? No, I don't think so. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html